From owner-svn-src-head@freebsd.org Fri May 25 20:03:00 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 985EDEF2F0E; Fri, 25 May 2018 20:03:00 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-it0-x232.google.com (mail-it0-x232.google.com [IPv6:2607:f8b0:4001:c0b::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 300A871CED; Fri, 25 May 2018 20:03:00 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-it0-x232.google.com with SMTP id e20-v6so8273142itc.1; Fri, 25 May 2018 13:03:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=dkfLG56k44pB2Ze2kcgAIXxctRAM0PX+81gBrF858JQ=; b=hk7rVznwGo0HMkEqvJdcFdp9jN0I5LughEkxBJ2DIrWDBG7W25U/ZYXQ1Sy0+tXF3/ pzRLTw0glXB82GVFEVtN0hGl9F9wyddxrY+lAGYXYgI1NWQ6rzEw3jrbx9fNDsDiwWUn YiDgKHNmfromMEeqF4rUZ2mbOw5/pvw8shFjc71YJ/DcHQIecyqgf1UfM7Eqt5GZ+s39 nEfH2GzJyHQ6dZkoI8OQZw4izl7uewWTpTBpDGRONrl3N3rcHLz/qbrYvnPqPU/3oRSu uHt5U1rdAQnuhOTlQaLbktuppjiUrJaB8O8Uo5qi4A9NHlHQl8ejIMS3iWJlCIJSgtk7 UU9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=dkfLG56k44pB2Ze2kcgAIXxctRAM0PX+81gBrF858JQ=; b=FybGFlZJv0ewRrhvbxmO3nUJafW0ZBdJhnN+BBQmYFfsbpUhtwgRyNtwPd51su1NTl M0Ggg6dHhDj0HkZ5YsFfLML8XhTE2lpSZQDnR27bOeLGLH6HwdzYulSwpCZxFXZdxD4/ WMzsHE879PNjrzRd92uBT8D78sg5OYye4/FHNf1qAH676yGiZqiGiQ+gxDArLCxE1PKx 3nt7mjwD9G/3NGcGIla0VoARDxGisk/jxMIZSies0Qii5S8lbXpHrIWOV+245F5FrZ8O ZLg89UzdG4xBPXDuSyanUOy2aW2ferzRW14dQ2rM+ItferG8SeqDZ7g8KU9aT1DsQWkc 9ioA== X-Gm-Message-State: ALKqPwdpUs54fDUwGD3u/OibE5PzDLmkkwnk0XS25YHwCz8FIvfc7HIN 3fisQmJV3UAgzUYEcHgObp5EsNw3wZ/xaYd1JiwhTg== X-Google-Smtp-Source: AB8JxZpL0IBa7Wg+Nnmkp1vZqLEqJTa4Onw4fLSwiHSsRMYOnGgOM75dtC6HG+DsiqyAwrxCKZEiJPgSS3n/rAEuwxQ= X-Received: by 2002:a24:8b41:: with SMTP id g62-v6mr3440748ite.114.1527278579360; Fri, 25 May 2018 13:02:59 -0700 (PDT) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 2002:a6b:82a7:0:0:0:0:0 with HTTP; Fri, 25 May 2018 13:02:38 -0700 (PDT) In-Reply-To: References: <201805250207.w4P275Pf060725@repo.freebsd.org> <20180525151134.GB99063@spindle.one-eyed-alien.net> <20180525174424.GD99063@spindle.one-eyed-alien.net> <20180525182139.GE99063@spindle.one-eyed-alien.net> From: Ed Maste Date: Fri, 25 May 2018 16:02:38 -0400 X-Google-Sender-Auth: J0Dr5avlUo4UE7_DJyU6ZXzrSIg Message-ID: Subject: Re: svn commit: r334199 - head/usr.sbin/bhyve To: Marcelo Araujo Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 May 2018 20:03:00 -0000 On 25 May 2018 at 14:26, Marcelo Araujo wrote: > >> The fact that we don't do NDEBUG builds normally does not allow us to >> ignore that it exists. It's perfectly reasonable for a user to build >> with CFLAGS+=NDEBUG. That need to work. If code is going to fail to >> handle resource errors with NDEBUG set then it needs something like this >> at the top of the file: > > Please document it in some place! NDEBUG is documented in assert(3). The man page should have more of an explanation (and examples) of the possible pitfalls of assert() though.