Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 28 Feb 2001 11:36:44 +0100
From:      Adrian Chadd <adrian@freebsd.org>
To:        freebsd-fs@freebsd.org
Cc:        freebsd-arch@freebsd.org
Subject:   mount fixes, part 1
Message-ID:  <20010228113644.A39251@roaming.cacheboy.net>

next in thread | raw e-mail | index | archive | help

Hi,

I'm running through and tidying up the mount interface, as promised.
My first set of patches aren't yet complete (there is at least one
documented strncpy() I have to fix up).

I am attempting to rework the VFS_MOUNT() vfsop to take kernel pointers,
rather than userland pointers. This will reduce the complexity by
removing the copyin*() functions and allow "other" syscall interfaces
to be used (eg linux, osf/1..)

jlemon did some initial work on this, but I've gone and redone his work.
I've moved the bulk of the mount process into a function called
vfs_mount(). mount() and the linux mount() use this function to mount
a filesystem. It is up to the syscall itself to worry about copyin*()ing.

Note that the mount data pointer is still a user pointer - fixing this
will require a *lot* more work, possibly by replacing it by a set of
sbufs or a set of attrib=value strings.

It is my hope that eventually vfs_mount() and VFS_MOUNT() will not
use copyin*() at all.

Comments are welcome. I'd like to commit this in the next couple of days
so I can continue with my VFS tidyups.

You can find my patch at http://people.freebsd.org/~adrian/mount.diff .

Note that I _will_ get to fixing the umount issues raised by mbr and
rwatson, but I want to get this set fixed first.

Thanks!



Adrian
-- 
Adrian Chadd			"Programming is like sex:
<adrian@freebsd.org>		   One mistake and you have to support for
				    a lifetime." -- rec.humor.funny


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010228113644.A39251>