From owner-freebsd-ports-bugs@freebsd.org Mon Aug 13 09:05:29 2018 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 066F3106B149 for ; Mon, 13 Aug 2018 09:05:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 97CE870DEF for ; Mon, 13 Aug 2018 09:05:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 59992106B146; Mon, 13 Aug 2018 09:05:28 +0000 (UTC) Delivered-To: ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 37B9A106B143 for ; Mon, 13 Aug 2018 09:05:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CC57F70DEB for ; Mon, 13 Aug 2018 09:05:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 309349362 for ; Mon, 13 Aug 2018 09:05:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w7D95R4v073205 for ; Mon, 13 Aug 2018 09:05:27 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w7D95RMk073194 for ports-bugs@FreeBSD.org; Mon, 13 Aug 2018 09:05:27 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 230267] [NEW PORT] x11-fm/fsv2: File system visualizer in 3D Date: Mon, 13 Aug 2018 09:05:26 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: romain@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Aug 2018 09:05:29 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D230267 Romain Tarti=C3=A8re changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |romain@FreeBSD.org --- Comment #1 from Romain Tarti=C3=A8re --- Looks great, I think I spotted a few issues: - The Makefile has an OPTIONS_SUN which does not exist. Maybe you intende= d an OPTIONS_SUB, but the pkg-plist does not have "%%NLS%%" and NLS is the only option configured), so I guess you can remove this line; - Only use +=3D when you have already done an assignation, and want to add something, generally conditionally (you can remove the '+' from the USES, USE_GNOME, USE_GL lines); - Set a LICENSE_FILE: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.htm= l#licenses-license_file Some cosmetic enhancements: - Avoid more than 80 chars on a single line (USE_GNOME can span 2 lines); - Porters usually try to align values between lines in the Makefile (verti= cal alignment), check that your editor use 8-space hard-tabs. This is purely cosmetic, but avoids distraction when you are reading a lot of Makefiles, making committers life easier :-) I think you will want to remove tabs to PORTNAME, CATEGORIES, MAINTAINER, COMMENT, LICENSE, and add tabs to USES, USE_GNOME, USE_GL, NLS_CONFIGURE_ENABLE, LIB_DEPENDS. When a variable name= is very long, it may make sense to break this rule, so instead of adding a tab= to NLS_CONFIGURE_ENABLE you may want to remove tabs to NLS_USES. (for example,= see https://svnweb.freebsd.org/ports/head/sysutils/puppet5/Makefile?revision=3D= 474935&view=3Dmarkup ) Thanks! --=20 You are receiving this mail because: You are the assignee for the bug.=