Date: Mon, 13 Aug 2018 09:05:26 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 230267] [NEW PORT] x11-fm/fsv2: File system visualizer in 3D Message-ID: <bug-230267-7788-D3a6b2ouus@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-230267-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-230267-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D230267 Romain Tarti=C3=A8re <romain@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |romain@FreeBSD.org --- Comment #1 from Romain Tarti=C3=A8re <romain@FreeBSD.org> --- Looks great, I think I spotted a few issues: - The Makefile has an OPTIONS_SUN which does not exist. Maybe you intende= d an OPTIONS_SUB, but the pkg-plist does not have "%%NLS%%" and NLS is the only option configured), so I guess you can remove this line; - Only use +=3D when you have already done an assignation, and want to add something, generally conditionally (you can remove the '+' from the USES, USE_GNOME, USE_GL lines); - Set a LICENSE_FILE: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.htm= l#licenses-license_file Some cosmetic enhancements: - Avoid more than 80 chars on a single line (USE_GNOME can span 2 lines); - Porters usually try to align values between lines in the Makefile (verti= cal alignment), check that your editor use 8-space hard-tabs. This is purely cosmetic, but avoids distraction when you are reading a lot of Makefiles, making committers life easier :-) I think you will want to remove tabs to PORTNAME, CATEGORIES, MAINTAINER, COMMENT, LICENSE, and add tabs to USES, USE_GNOME, USE_GL, NLS_CONFIGURE_ENABLE, LIB_DEPENDS. When a variable name= is very long, it may make sense to break this rule, so instead of adding a tab= to NLS_CONFIGURE_ENABLE you may want to remove tabs to NLS_USES. (for example,= see https://svnweb.freebsd.org/ports/head/sysutils/puppet5/Makefile?revision=3D= 474935&view=3Dmarkup ) Thanks! --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-230267-7788-D3a6b2ouus>