From owner-svn-ports-all@FreeBSD.ORG Mon Nov 5 08:14:14 2012 Return-Path: Delivered-To: svn-ports-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 06F27DF6; Mon, 5 Nov 2012 08:14:14 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id D4B9B8FC12; Mon, 5 Nov 2012 08:14:13 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id qA58EDCb083184; Mon, 5 Nov 2012 08:14:13 GMT (envelope-from bapt@FreeBSD.org) Received: (from bapt@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id qA58EDwq083148; Mon, 5 Nov 2012 08:14:13 GMT (envelope-from bapt@FreeBSD.org) X-Authentication-Warning: freefall.freebsd.org: bapt set sender to bapt@FreeBSD.org using -f Date: Mon, 5 Nov 2012 09:14:10 +0100 From: Baptiste Daroussin To: Olli Hauer Subject: Re: Remove unnecessary change to Mk/bsd.port.mk (: svn commit: r303619 - head/Mk) Message-ID: <20121105081410.GE66354@ithaqua.etoilebsd.net> References: <201209032047.q83Kl1dl041630@svn.freebsd.org> <5097534E.8030604@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="lkTb+7nhmha7W+c3" Content-Disposition: inline In-Reply-To: <5097534E.8030604@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@FreeBSD.org, fjoe@FreeBSD.org, svn-ports-all@FreeBSD.org, Gerald Pfeifer , "ports-committers@freebsd.org" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Nov 2012 08:14:14 -0000 --lkTb+7nhmha7W+c3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 05, 2012 at 06:49:02AM +0100, Olli Hauer wrote: > On 2012-11-04 15:09, Gerald Pfeifer wrote: > > I understand Mk/bsd.port.mk is not applicable for maintainer=20 > > timeouts or I would have gone ahead and committed the patch > > below. > >=20 > > Can you please have a look? > >=20 > > Thanks, > > Gerald > >=20 > > On Wed, 5 Sep 2012, Gerald Pfeifer wrote: > >>> +CONFIGURE_ENV+=3D CPPFLAGS=3D"${CPPFLAGS}" LDFLAGS=3D"${LDFLAGS}" > >>> +.endif > >> > >> Really? > >> > >> Something looks fundamentally wrong if you have to do this under > >> .if defined(USE_READLINE), at least past > >> > >> r270411 | erwin | 2011-03-07 07:32:05 +0000 (Mon, 07 Mar 2011) | 5 l= ines > >> > >> Pass CPPFLAGS to MAKE_ENV and CONFIGURE_ENV > >> > >> PR: 153625 > >> Submitted by: gerald > >> > >> How about the patch below? > >> > >> Gerald > >> > >> Index: bsd.port.mk > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > >> --- bsd.port.mk (revision 303674) > >> +++ bsd.port.mk (working copy) > >> @@ -1708,7 +1708,6 @@ > >> LIB_DEPENDS+=3D readline.6:${PORTSDIR}/devel/readline > >> CPPFLAGS+=3D -I${LOCALBASE}/include > >> LDFLAGS+=3D -L${LOCALBASE}/lib -lreadline > >> -CONFIGURE_ENV+=3D CPPFLAGS=3D"${CPPFLAGS}" LDFLAGS=3D"${LDFLAGS}" > >> .endif > >> .endif > >> =20 > >=20 >=20 > Maybe fjoe@ can explain why CONFIGURE_ENV was placed here. > The line was part of PR 162995. >=20 >=20 Speaking of this, USE_READLINE is anyway buggy, because it forces linking o= ver libreadline at first but to not take care of the related ncurses, which cou= ld be the one from the ports or the one from base. security/authforce is a good port to try USE_READLINE on recent current bui= lding just fail because of it. I have no clue on how to make USE_READLINE smarter. regards, Bapt --lkTb+7nhmha7W+c3 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlCXdVIACgkQ8kTtMUmk6Ez60QCgwSLrKOjxke3mNcfMBNhCJiwV hcoAn1rHxAdaTMW4DS35FTtxlTZyg++5 =SuHE -----END PGP SIGNATURE----- --lkTb+7nhmha7W+c3--