From nobody Fri Oct 13 23:43:11 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S6jk74lYkz4wxrt; Fri, 13 Oct 2023 23:43:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S6jk744SJz3FdX; Fri, 13 Oct 2023 23:43:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697240591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lbASgz8j5hUX7MZQmdMsVgczp+eV1QiCaPZG2hx7EaA=; b=IBsrGNZfJEtIbb8QvX/SBWobK+HeuK99tW8uQOI5FkPhq0pNmDkLkti9T6ewOj+Lqz9uJy kuFuU9ObfID9My4BlOOSukY9MhSGORZiDDIGYsQhRArphuc6PpJtHT1g35EJXTNLYShdxl 9VeMxLlzXvkwxPJ3wQjIpgtXNIYRFkADjZiG1PdvpSG+TWVEjfzKvRdhyzBJ+gue4uJVd8 8diwVYmdx9hfQiY49oTQSyfHzIfm1OUul7JzQQf6nRzJauvcKmeOX2BbCHjQGK02myFn7J 31y3kHchGkqv9t7iTY4cphibO9ohD8jMlKTXB6/PiXq5T8tHuK6ODJp79gMmcA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697240591; a=rsa-sha256; cv=none; b=YxYzJyh6GO8C8N6H9DZSh0zgD0FGa6gBXlPP+4L02XCukoO8D0yh84hwgWMdmo5OGw81Kj 4VLzla6FZv3C5Muy9RVyXEMOZrS/CDg7aunbp+/iZrdx5eCO8R6eke2eTTk2ktNf8hzrXQ 7nB3Ieabg0zqtVumE6Dr7RYKxVSEjlTvpTKLux5j6wL735Ov8Ozf39v6nKFoPQkQ8zytWa s9gaiIFZqvPu3OI0M4NY8NyVl7QTwqBrYogz8MPgjS4+rsAR6Gp0/qyRDo0Mb5b5z9Yzlh dKhnlvz2CPN+m5sdRNPFS/2Opdc59MCOpblTociucNP4oNockgp2mjGEYOjaTA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697240591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lbASgz8j5hUX7MZQmdMsVgczp+eV1QiCaPZG2hx7EaA=; b=WtSpQtPcvtG8ZhNpKqt6cfLRFUyKAPmGil8IMUscMmHKkaedZF9nB1uc8JLKzMunuyEbDr FCPBQTkgWzlylrQxxLkdI5zA22nFdNw5BP5OLCM7zJT0p4ONPjBHleeikpOKb8NP9ePbwQ OWU0YVSmpRTsEIImnHvxCVu2VHUPzuUvoPjOko4CCvi0mlEk2IlO4vrobg2YBPrn0S/psm rw08qFYqkV8QIFXnXVcBSE89XvXol3aW0KAN/1UDFkGIdN/O0RMxODifJ2DDj2RA7irWmc Zv+1SB5gItcBLNIvL/o1hXfDOSHyOCCjZqNGvKjIwFqeGVUBn0ZdBbjtI8SVwQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S6jk739Xnz17VF; Fri, 13 Oct 2023 23:43:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 39DNhBj0014767; Fri, 13 Oct 2023 23:43:11 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 39DNhBEL014764; Fri, 13 Oct 2023 23:43:11 GMT (envelope-from git) Date: Fri, 13 Oct 2023 23:43:11 GMT Message-Id: <202310132343.39DNhBEL014764@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mateusz Guzik Subject: git: 5cf1c99d4c42 - stable/14 - vfs: consult freevnodes in vnlru_kick_cond List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 5cf1c99d4c425ab196dfa3bafcf3a5f142eab887 Auto-Submitted: auto-generated The branch stable/14 has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=5cf1c99d4c425ab196dfa3bafcf3a5f142eab887 commit 5cf1c99d4c425ab196dfa3bafcf3a5f142eab887 Author: Mateusz Guzik AuthorDate: 2023-10-10 16:19:53 +0000 Commit: Mateusz Guzik CommitDate: 2023-10-13 23:41:46 +0000 vfs: consult freevnodes in vnlru_kick_cond If the count is high enough there is no point trying to produce more. Not going there reduces traffic on the vnode_list mtx. This further shaves total real time in a test mentioned in: 74be676d87745eb7 ("vfs: drop one vnode list lock trip during vnlru free recycle") -- 20 instances of find each creating 1 million vnodes, while total limit is set to 400k. Time goes down from ~41 to ~35 seconds. Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit 23ef25d25d989e7213bc1d3ef32b0f48a9eb2537) --- sys/kern/vfs_subr.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c index e7e612254ba2..5e39a149ef36 100644 --- a/sys/kern/vfs_subr.c +++ b/sys/kern/vfs_subr.c @@ -1584,6 +1584,9 @@ static void vnlru_kick_cond(void) { + if (vnlru_read_freevnodes() > wantfreevnodes) + return; + if (vnlruproc_sig) return; mtx_lock(&vnode_list_mtx); @@ -1849,9 +1852,8 @@ vn_alloc_hard(struct mount *mp) } alloc: mtx_assert(&vnode_list_mtx, MA_NOTOWNED); - rnumvnodes = atomic_fetchadd_long(&numvnodes, 1) + 1; - if (vnlru_under(rnumvnodes, vlowat)) - vnlru_kick_cond(); + atomic_add_long(&numvnodes, 1); + vnlru_kick_cond(); return (uma_zalloc_smr(vnode_zone, M_WAITOK)); }