From owner-cvs-sys  Wed Oct  4 04:28:14 1995
Return-Path: owner-cvs-sys
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id EAA10703
          for cvs-sys-outgoing; Wed, 4 Oct 1995 04:28:14 -0700
Received: from Root.COM (implode.Root.COM [198.145.90.17])
          by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id EAA10697
          ; Wed, 4 Oct 1995 04:27:53 -0700
Received: from corbin.Root.COM (corbin [198.145.90.50]) by Root.COM (8.6.12/8.6.5) with ESMTP id EAA19509; Wed, 4 Oct 1995 04:26:24 -0700
Received: from localhost (localhost [127.0.0.1]) by corbin.Root.COM (8.6.12/8.6.5) with SMTP id EAA00513; Wed, 4 Oct 1995 04:27:44 -0700
Message-Id: <199510041127.EAA00513@corbin.Root.COM>
To: Peter Wemm <peter@jhome.dialix.com>
cc: Julian Elischer <julian@freefall.freebsd.org>,
        CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org
Subject: Re: cvs commit: src/sys/i386/linux linux_misc.c 
In-reply-to: Your message of "Wed, 04 Oct 95 18:16:04 +0800."
             <Pine.BSF.3.91.951004180907.1120G-100000@jhome.DIALix.COM> 
From: David Greenman <davidg@Root.COM>
Reply-To: davidg@Root.COM
Date: Wed, 04 Oct 1995 04:27:43 -0700
Sender: owner-cvs-sys@FreeBSD.org
Precedence: bulk

>On Wed, 4 Oct 1995, Julian Elischer wrote:
>> julian      95/10/04 00:08:05
>> 
>>   Modified:    sys/i386/i386  trap.c
>>                sys/i386/linux  linux_misc.c
>>   Log:
>>   Submitted by:	Juergen Lock <nox@jelal.hb.north.de>
>>   Obtained from: other people on the net ?
>>   
>>   1. stepping over syscalls (gdb ni) sends you to DDB, and returned
>>   to the wrong address afterwards, with or without DDB.  patch in
>>   i386/i386/trap.c below.
>>   
>>   2. the linux emulator (modload'ed) still causes panics with DIAGNOSTIC,
>>   re-applied a patch posted to one of the lists...
>
>BTW: #2 looks exactly like my patch that I posted some months ago on the 
>lists..
>
>If I remember rightly, Terry complained about the changes that I made, 
>saying that it's bad news having a dozen or so "return"s in the function 
>all trying to keep track of the changing locking state, and I agree with 
>him.  I rewrote it after cleaning it up, but never got a chance to do 
>anything with it, as jhome lost it's filesystem...

   If you had changed it to contain too many goto's, I would have complained,
too, especially since I'm the author of most of the current trap() function.
:-)

-DG