From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Aug 13 06:40:02 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id F3884C10 for ; Tue, 13 Aug 2013 06:40:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id D19242CD6 for ; Tue, 13 Aug 2013 06:40:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r7D6e1pH028274 for ; Tue, 13 Aug 2013 06:40:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r7D6e12b028273; Tue, 13 Aug 2013 06:40:01 GMT (envelope-from gnats) Resent-Date: Tue, 13 Aug 2013 06:40:01 GMT Resent-Message-Id: <201308130640.r7D6e12b028273@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, John Marshall Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 18D39B7A for ; Tue, 13 Aug 2013 06:34:57 +0000 (UTC) (envelope-from john.marshall@riverwillow.com.au) Received: from mail1.riverwillow.net.au (mail1.riverwillow.net.au [203.58.93.36]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 970052C9E for ; Tue, 13 Aug 2013 06:34:55 +0000 (UTC) Received: from rwsrv08.mby.riverwillow.net.au (localhost [127.0.0.1]) by mail1.riverwillow.net.au (8.14.7/8.14.7) with ESMTP id r7D6JbkP018745 for ; Tue, 13 Aug 2013 16:19:37 +1000 (EST) Received: (from john@localhost) by rwsrv08.mby.riverwillow.net.au (8.14.7/8.14.7/Submit) id r7D6Jbxb018744; Tue, 13 Aug 2013 16:19:37 +1000 (EST) Message-Id: <201308130619.r7D6Jbxb018744@rwsrv08.mby.riverwillow.net.au> Date: Tue, 13 Aug 2013 16:19:37 +1000 (EST) From: John Marshall To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.114 Subject: ports/181248: [PATCH] print/cups-base Disable INSTALLS_ICONS for non-X11 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: John Marshall List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Aug 2013 06:40:02 -0000 >Number: 181248 >Category: ports >Synopsis: [PATCH] print/cups-base Disable INSTALLS_ICONS for non-X11 >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Aug 13 06:40:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: John Marshall >Release: FreeBSD 9.2-RC1 amd64 >Organization: Riverwillow Pty Ltd >Environment: System: FreeBSD rwsrv08.mby.riverwillow.net.au 9.2-RC1 FreeBSD 9.2-RC1 #0 r254103: Fri Aug 9 09:30:29 AEST 2013 root@rwsrv08.mby.riverwillow.net.au:/usr/obj/usr/src/sys/RWSRV08 amd64 >Description: r324269 introduced INSTALLS_ICONS to the Makefile. This has the wonderful side-effect of pulling in the entire GNOME toolchain on a server. How about wrapping this baby in a conditional blanket so that more server admin's don't have to spend ages trying to figure out what pulled in all those GUI ports? >How-To-Repeat: cd /usr/ports/print/cups-base make depends >Fix: Neither r324269 (which introduced INSTALLS_ICONS) nor r324428 (which moved its location) bumped PORTREVISION, so this patch doesn't either. --- cups-base_324646.diff begins here --- Index: print/cups-base/Makefile =================================================================== --- print/cups-base/Makefile (revision 324646) +++ print/cups-base/Makefile (working copy) @@ -67,7 +67,9 @@ LICENSE= LGPL21 OPTIONS_DEFINE= GNUTLS .else +.if !defined(WITHOUT_X11) INSTALLS_ICONS= yes +.endif PORTREVISION= 1 CUPS_SUFFIX= -base OPTIONS_DEFINE= GNUTLS LIBPAPER PHP PYTHON PAM LDAP DBUS LIBUSB XDG_OPEN GHOSTSCRIPT XPDF AVAHI MDNSRESPONDER --- cups-base_324646.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: