From owner-freebsd-arm@FreeBSD.ORG  Wed Mar  4 15:22:10 2015
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id D9852D62
 for <freebsd-arm@freebsd.org>; Wed,  4 Mar 2015 15:22:10 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id B58B91FF
 for <freebsd-arm@freebsd.org>; Wed,  4 Mar 2015 15:22:10 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t24FM9Od047754
 for <freebsd-arm@freebsd.org>; Wed, 4 Mar 2015 15:22:09 GMT
 (envelope-from root@phabric-backend.isc.freebsd.org)
Received: (from root@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t24FM98m047753;
 Wed, 4 Mar 2015 15:22:09 GMT (envelope-from root)
Date: Wed, 4 Mar 2015 15:22:09 +0000
To: freebsd-arm@freebsd.org
From: "imp (Warner Losh)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Commented On] D2005: Start of arm64 toolchain support
 (sufficient for kernel-toolchain)
Message-ID: <b38507d780bd6d08320ef3c4cac92d33@localhost.localdomain>
X-Priority: 3
Thread-Topic: D2005: Start of arm64 toolchain support (sufficient for
 kernel-toolchain)
X-Herald-Rules: <23>
X-Phabricator-To: <PHID-USER-axkijn4pfdxlezgbnt7g>
X-Phabricator-To: <PHID-USER-xp4awsksj2i7uxrs25tm>
X-Phabricator-Cc: <PHID-USER-q5lmute3rwskeizvu5gf>
X-Phabricator-Cc: <PHID-USER-pns6zgllnr6ze4h7ms3o>
X-Phabricator-Cc: <PHID-MLST-stsrni3uozki6w7zubvy>
In-Reply-To: <differential-rev-PHID-DREV-xkiyys7g7nptp5rxbteo-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-xkiyys7g7nptp5rxbteo-req@FreeBSD.org>
Thread-Index: MWIwYjI4MjVhOWQ4NTczNDM4ZTQ0MzM1OTZhIFT3IyE=
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "Porting FreeBSD to ARM processors." <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm/>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Mar 2015 15:22:10 -0000

imp added a comment.

Not quite ready for prime time, and adds extra warts to the build system that don't need to be added to it.

INLINE COMMENTS
  Makefile.inc1:325 This is ugly. Why is aarch64 special? Why wouldn't we need it for sparc64 if we removed ld and gcc? I really don't like this at all.
  
   I know it is here for convenience, but there's got to be a more generic way to do it.
  share/mk/bsd.endian.mk:6 This shouldn't reference MACHINE. I should fix that.
  share/mk/src.opts.mk:233-238 This is wrong on a number of levels.
  
  We generally opt-out of binaries in the .mk files.
  It allows people to set them to 'yes' even though it can't possibly work.
  
  We really need an "__ALWAYS_NO" which could be set based on what
  arch you are on. I can add that. binuitls might be that specail.
  
  gdb certainly isn't.

REVISION DETAIL
  https://reviews.freebsd.org/D2005

To: emaste, bdrewery
Cc: imp, andrew, freebsd-arm