From owner-freebsd-current@FreeBSD.ORG Wed Dec 5 00:59:45 2012 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2DB0FE81 for ; Wed, 5 Dec 2012 00:59:45 +0000 (UTC) (envelope-from jroberson@jroberson.net) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id E9E1D8FC0C for ; Wed, 5 Dec 2012 00:59:44 +0000 (UTC) Received: by mail-pb0-f54.google.com with SMTP id wz12so3258770pbc.13 for ; Tue, 04 Dec 2012 16:59:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type:x-gm-message-state; bh=X3k36V4wy6fA4R1NSrA77bYUAmCa2GVikSSYuxAK1Gc=; b=UDTKiI3IguHOjjApL6161wstBnS69NGrT9BAzY8ChSf0/KImxnah/hq5BZEFfUM3eU +bmSCW0hK6nDw5BVP+mOegC1Jo3Gu+hZ5LFObodBia0YhdAZ0G6BMZqWXiuw4RwHNvaL cgCqjl4/fzEsIEYkEaWtkawf16IZDH5Gfc5F0DPqwdObhG/qqHEg1A78Rtk+UmEjJokb mFo+51+DSty550MJk7LKk+9T3473+cjRmZKvsfJrrn0aVCkhAetOSFUYwpkDbbG46xC3 YnEP4FihS/fvOEK7iECTjATN+MeWzg3EIeu9R+TvyZoCZwC6AQKfxl6U5PygVpuZl0Kx qcpw== Received: by 10.68.197.197 with SMTP id iw5mr43374127pbc.22.1354669184397; Tue, 04 Dec 2012 16:59:44 -0800 (PST) Received: from rrcs-66-91-135-210.west.biz.rr.com (rrcs-66-91-135-210.west.biz.rr.com. [66.91.135.210]) by mx.google.com with ESMTPS id o6sm1638191paw.37.2012.12.04.16.59.42 (version=SSLv3 cipher=OTHER); Tue, 04 Dec 2012 16:59:43 -0800 (PST) Date: Tue, 4 Dec 2012 14:58:24 -1000 (HST) From: Jeff Roberson X-X-Sender: jroberson@desktop To: Ian Lepore Subject: Re: Call for testers, users with scsi cards In-Reply-To: <1354658563.87661.23.camel@revolution.hippie.lan> Message-ID: References: <1354658563.87661.23.camel@revolution.hippie.lan> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Gm-Message-State: ALoCoQklPBSrJtBit09Du3EtDnQ2439rxHw3LUcyOegyll4jtE15ZRf7uTO/sDfoGt/dh6OiRKJc Cc: current@freebsd.org, Warner Losh X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Dec 2012 00:59:45 -0000 On Tue, 4 Dec 2012, Ian Lepore wrote: > On Tue, 2012-12-04 at 14:49 -0700, Warner Losh wrote: >> On Dec 4, 2012, at 2:36 PM, Jeff Roberson wrote: >> >>> http://people.freebsd.org/~jeff/loadccb.diff >>> >>> This patch consolidates all of the functions that map cam control blocks for DMA into one central function. This change is a precursor to adding new features to the I/O stack. It is mostly mechanical. If you are running current on a raid or scsi card, especially if it is a lesser used one, I would really like you to apply this patch and report back any problems. If it works you should notice nothing. If it doesn't work you will probably panic immediately on I/O or otherwise no I/O will happen. >> >> I haven't tested it yet. My only comment from reading it though would be to make subr_busdma.c be dependent on cam, since it can only used from cam. We've grown sloppy about noting these dependencies in the tree... >> >> Warner > > Hmmm, if it's only used by cam, why isn't it in cam/ rather than kern/ ? kib pointed out drivers that use ccbs but do not depend on cam. I also intend to consolidate many of the busdma_load_* functions into this subr_busdma.c eventually. I will add a load_bio and things like load_uio and load_mbuf don't need to be re-implemented for every machine. I will define a MD function that allows you to add virtual or physical segments piecemeal (as they all currently have) so that function may be called for each member in the uio, mbuf, ccb, or bio. Thanks, Jeff > > -- Ian >