From owner-svn-ports-all@freebsd.org Sat Sep 19 11:51:57 2015 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 64C99A030DD; Sat, 19 Sep 2015 11:51:57 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 54B4E1A4F; Sat, 19 Sep 2015 11:51:57 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 532381C2C; Sat, 19 Sep 2015 11:51:57 +0000 (UTC) Date: Sat, 19 Sep 2015 11:51:57 +0000 From: Alexey Dokuchaev To: marino@freebsd.org Cc: Mathieu Arnold , "Timur I. Bakeyev" , Dmitry Marakasov , ports-committers@freebsd.org, svn-ports-all , svn-ports-head Subject: Re: svn commit: r396998 - head/net/samba36 Message-ID: <20150919115157.GA99928@FreeBSD.org> References: <201509151622.t8FGMXQY074723@repo.freebsd.org> <0FAE77426236E9E47E15BFC1@atuin.in.mat.cc> <20150919072048.GA86129@FreeBSD.org> <55FD0FA4.7050306@marino.st> <20150919074241.GA96797@FreeBSD.org> <55FD3620.7060500@marino.st> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55FD3620.7060500@marino.st> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Sep 2015 11:51:57 -0000 On Sat, Sep 19, 2015 at 12:17:04PM +0200, John Marino wrote: > On 9/19/2015 9:42 AM, Alexey Dokuchaev wrote: > > I'm fine with clear and umabiguous rules too. I just want bumping rules > > to become more granular. Plain "package changed -> need a bump" means > > that fixing a typo in pkg-descr would require it. Don't you think this > > is a bit too extreme? > > I think there is already an exception for metadata changes such as > pkg-descr and COMMENT and MAINTAINER, although I don't know if this > exception is documented (it is done in practice). However shebang fixes > are functional and definitely need a bump. They can be the difference > between functioning and non-functioning packages. Right; however, in this particular case it was *examples* what were fixed, which in fact are not ready to be run on FreeBSD as is. I can totaly see why Timur got upset about this particular bump. ./danfe