From owner-freebsd-virtualization@freebsd.org Thu Mar 19 12:55:51 2020 Return-Path: Delivered-To: freebsd-virtualization@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3FBC425FC58 for ; Thu, 19 Mar 2020 12:55:51 +0000 (UTC) (envelope-from wanpengqian@gmail.com) Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48jn2Y1t2cz4fNF for ; Thu, 19 Mar 2020 12:55:49 +0000 (UTC) (envelope-from wanpengqian@gmail.com) Received: by mail-lf1-x136.google.com with SMTP id a28so1500915lfr.13 for ; Thu, 19 Mar 2020 05:55:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=KhvNtFg4baNc8z/wEY2frUAdZbPr0V8758lb3Few4Pk=; b=aucJSD/06QXpK9Kql3tB8ehpatpOgsue2Lrz3VPJgMs5ORrYqGM9TE1NaCkfu0L3pN 1rN3Wzv1Acb+oas2jxJJfogdKQ37gSlcK16Dyuvf/40gKL8mv1j91QzVwvXnh7eMC65U 0FuCcGJAIwk4htlmMA9Aer1BBICO3e8dp4B0WQirdAfE19eqisoQSA+L/eoOyFqSDXeF TJrlLgOHyO25C47wb3oVvi3ta9EuSkEY3V5WB7My12nsjkHq6uB4uAWp4WXGlFg7zWfg FRGVDYzTckkWNgBiz0j+uNfmazpgTqntsqcf1zLM8qfy0wlpvJUk99gyQuE0LQuOyZ0d th4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=KhvNtFg4baNc8z/wEY2frUAdZbPr0V8758lb3Few4Pk=; b=R9aqIwdayuG14Pd/o1iDKwm0S3lxy2aYO3X0QchONo6f5N08QDjyVyJk6aM6pDGoHY 3LpoUgbnWKgWBcMQfNd7zvvsAduS0SgRz5ozIKvzgj1FUWWr7y3vhdmOsqaqZwYHDi1c PmR4PlCI0Gh9kK8s5xRHH9xEP8WKW4HgKQaCRDFwuidp3Z/itfHdCD+osFyXdRDCKpei NB6mprJMJNQmPllu65KRgwRrAR67G6S2AyXON0Qmb/Q46IdYQLm5ZEeuS7x+YHbPFAhA gBemFG6FTB9CfUWP+ffgTIRnXeC9PTETg7uqwg0og16L+TPZD1gCzKXkjY1rJmDfVwB3 J6Mw== X-Gm-Message-State: ANhLgQ3Kssz54Nli32Gs79Az73TNEz0S7ZtblelzB36eRQncu/igK6iA dPKa8/1pPGpqhMpnIxr/5oOFD4+7u/K9FRnG8lvGispq/XI= X-Google-Smtp-Source: ADFU+vt1ezwgDbKk7Gb9HLvbPhMoHMt5VBY2NO8ChuGprS/5zle8iIwYxObtPATOiyF7hK0TILn7/E/gIUYv7QzQ1NQ= X-Received: by 2002:a19:8213:: with SMTP id e19mr2094453lfd.201.1584622546571; Thu, 19 Mar 2020 05:55:46 -0700 (PDT) MIME-Version: 1.0 From: Wanpeng Qian Date: Thu, 19 Mar 2020 21:54:59 +0900 Message-ID: Subject: bhyve: TRIM support in AHCI controller To: FreeBSD virtualization Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 48jn2Y1t2cz4fNF X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=aucJSD/0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of wanpengqian@gmail.com designates 2a00:1450:4864:20::136 as permitted sender) smtp.mailfrom=wanpengqian@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-virtualization@freebsd.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE_FREEMAIL(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; IP_SCORE(0.00)[ip: (-9.61), ipnet: 2a00:1450::/32(-2.39), asn: 15169(-1.65), country: US(-0.05)]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[6.3.1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Mar 2020 12:55:51 -0000 Hi all I found the output of diskinfo inside VM of AHCI disk as follow, no TRIM support. root@smart:~ # diskinfo -v ada0 ada0 512 # sectorsize 21474836480 # mediasize in bytes (20G) 41943040 # mediasize in sectors 131072 # stripesize 0 # stripeoffset 41610 # Cylinders according to firmware. 16 # Heads according to firmware. 63 # Sectors according to firmware. BHYVE SATA DISK # Disk descr. BHYVE-0B98-104F-E9A7 # Disk ident. No # TRIM/UNMAP support 0 # Rotation rate in RPM Not_Zoned # Zone Mode Also camcontrol identify ada0 -v show not support of TRIM Data Set Management (DSM/TRIM) no I check to pci_ahci.c, TRIM support is decided by block_if.c's candelete flag. while candelete is decided here strlcpy(arg.name, "GEOM::candelete", sizeof(arg.name)); arg.len = sizeof(arg.value.i); if (ioctl(fd, DIOCGATTR, &arg) == 0) candelete = arg.value.i; Obvious file backend will not have the candelete flag. If the backend storage support TRIM, I think we should present TRIM ability to VM. Any better idea to check whether backend storage support TRIM or not, so we can enable it. Thanks.