From owner-svn-src-stable@FreeBSD.ORG Thu Oct 2 21:21:38 2014 Return-Path: Delivered-To: svn-src-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B96BB171; Thu, 2 Oct 2014 21:21:38 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8301B35D; Thu, 2 Oct 2014 21:21:38 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 55131B977; Thu, 2 Oct 2014 17:21:37 -0400 (EDT) From: John Baldwin To: Glen Barber Subject: Re: svn commit: r272372 - stable/10/bin/rm Date: Thu, 2 Oct 2014 17:13:57 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20140415; KDE/4.5.5; amd64; ; ) References: <201410011618.s91GIfR5071251@svn.freebsd.org> <20141002141656.Y1807@besplex.bde.org> <20141002061628.GO1275@hub.FreeBSD.org> In-Reply-To: <20141002061628.GO1275@hub.FreeBSD.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201410021713.57943.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Thu, 02 Oct 2014 17:21:37 -0400 (EDT) Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-10@freebsd.org, Bruce Evans X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Oct 2014 21:21:38 -0000 On Thursday, October 02, 2014 2:16:28 am Glen Barber wrote: > On Thu, Oct 02, 2014 at 02:56:05PM +1000, Bruce Evans wrote: > > On Wed, 1 Oct 2014, Glen Barber wrote: > > > > >Log: > > > MFC r268376 (imp): > > > > > > rm -rf can fail sometimes with an error from fts_read. Make it > > > honor fflag to ignore fts_read errors, but stop deleting from > > > that directory because no further progress can be made. > > > > I asked for this to be backed out in -current. It is not suitable for MFC. > > > > It fixes an immediate issue that prevents high-concurrent make(1) jobs > from stomping over each other. > > If there is a more suitable solution, it needs to be introduced in head/ > first, pending MFC for 10.1-RELEASE. > > In the meantime, we lack any alternate fix, and this resolves the > immediate issue at hand. > > > See old mail for more details. > > > > I saw the original email. I do not see a proposed patch. I think the proposed patch is to revert this and fix the broken Makefiles instead. The problem with changing rm to workaround a bug in FreeBSD's Makefiles is we are breaking rm(1) for everyone else in the world to cater to a bug in our build system. Are you happy that we are invoking the same commands in parallel for a make target? In some cases it may be ok, but there are many others where it is not (e.g. if two jobs are both compiling the same .o file, the second one might replace an object file out from under a subsequent link that starts after the first one finishes). Instead of breaking rm, you should be harassing whoever broke make (or added the SUBDIR_PARALLEL logic). Presumably you can build without -j as a workaround. -- John Baldwin