From owner-cvs-all@FreeBSD.ORG Mon Nov 26 20:40:42 2007 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A8CC816A476; Mon, 26 Nov 2007 20:40:42 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 6213C13C44B; Mon, 26 Nov 2007 20:40:42 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.1/8.14.1) with ESMTP id lAQKbdOd052013; Mon, 26 Nov 2007 13:37:40 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Mon, 26 Nov 2007 13:37:39 -0700 (MST) Message-Id: <20071126.133739.21879307.imp@bsdimp.com> To: obrien@freebsd.org From: Warner Losh In-Reply-To: <20071126173127.GB76927@dragon.NUXI.org> References: <47476A52.8040508@FreeBSD.org> <20071124001008.GA44735@what-creek.com> <20071126173127.GB76927@dragon.NUXI.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, jb@freebsd.org, jb@what-creek.com Subject: Re: cvs commit: src/contrib/binutils/opcodes ppc-dis.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Nov 2007 20:40:42 -0000 From: "David O'Brien" Subject: Re: cvs commit: src/contrib/binutils/opcodes ppc-dis.c Date: Mon, 26 Nov 2007 09:31:27 -0800 > On Sat, Nov 24, 2007 at 12:10:08AM +0000, John Birrell wrote: > > On Sat, Nov 24, 2007 at 01:03:30AM +0100, Kris Kennaway wrote: > > > John Birrell wrote: > > > >jb 2007-11-23 23:54:45 UTC > > > > > > > > FreeBSD src repository > > > > > > > > Modified files: > > > > contrib/binutils/opcodes ppc-dis.c > > > > Log: > > > > Fix strict alias warnings. > > > > > > > > Revision Changes Path > > > > 1.2 +119 -37 src/contrib/binutils/opcodes/ppc-dis.c > > > > > > Usually we try to avoid taking files off the vendor branch, it causes > > > trouble for the person doing the vendor imports :( > > > > I know that. I nearly mentioned it in the commit message. > > > > I think it's a change that doesn't need to be merged. If a new version > > is imported, _that_ needs to be build clean. > > PLEASE discuss changes like this before committing them. > For one, we typically don't go around fixing warnings in contributed > code. Second a courtesy email to me (or IRC poke) would have been nice - > as I've been talking with the embedded folks about their needs for a > binutils upgrade > - you've just added more effort to the task - *forever*. Because once a file is off the vendor branch, the import is no longer one command (cvs import) but several as one needs to do a 'cvs update -j xxx-1 -j xxx' and then a commit after a sanity check. There is no way to put a file back on the vendor branch without breaking date checkout, so we as a project never do that. It would have been better to do a 'cvs import' of your changes, even if they didn't make it upstream.... Warner