From nobody Sat Jan 10 20:54:00 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dpW8v4V70z6MtNQ for ; Sat, 10 Jan 2026 20:54:23 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dpW8v07smz3JWB for ; Sat, 10 Jan 2026 20:54:18 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-2a0a95200e8so30666905ad.0 for ; Sat, 10 Jan 2026 12:54:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1768078452; x=1768683252; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=B57O3aqxwdPUXi6D6FN72Ln6KDjc3KOlNGO039TTMF8=; b=BzDIpHe6Y+nMMCXVpCuQglSfD25WzEUiLXEl2pEZXPK7jeWsuHrG7V3YdHe9f+kfV1 FgAeQVfxMOXyKhuzFnxcRMtMhdkPA+PNWNm2PSqM2X40Swzeo/54uzLgNNsHxO6qluTs LVU6dIGsQtCVeCBH3Nl4AoOf6hho7Gqs7D9FcU6rqAUqnHtxwOPXich0P1EpCZj9wdvb WObIQC0J0SlTxvq5E30USrHAaGuoNZ3grvl3WVgFGbWWt5eJaI1Kl+smeH8KryCofAEd 8emHtd5uwiT7KXhdLJPiILHG82euAJ+wd1GwotquC2q7Kv3uiMtwQP6lzuaVJxqjEYgT hJ8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768078452; x=1768683252; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=B57O3aqxwdPUXi6D6FN72Ln6KDjc3KOlNGO039TTMF8=; b=f6LAEONxNhWqbCKOsDuuzXCvkLtBKu6rcOY1vUDEoQkqzaj8b19dxiSVnrlUG+nR0r h+9JPuxkPvwJtmhPMUA/Nchb2hjicZPr9KN43zQUUy5N9V4FcqnkJ37f8go8wflZ1aCZ IvveWWTkQpkmO89FOgwVYXAUELIbq98Iyjhps1a2Q0o5urdUNL15M1kWJKQAfllEOoc4 X5IR/sjCb64fkPHOtTyfOT28XX5+JBnzDkPs2Xrx0fkQWu1VVNE/u99N/CIKn5utsyhe EUWHFda8e7Lk6uq/itMVfx+WbmIMf39Y3dr8ETj3Gxe9glhZpnmAp4oPPsEF3ImidJsF DRFA== X-Forwarded-Encrypted: i=1; AJvYcCWoL9PkgAjtPOvkR6GoOKdfRSrAeknnX0iYerpbnKWRMfQlml4vfFYzVpKGZrc0ohirgMX2MnjicRasqtDKzeDvtRhW@freebsd.org X-Gm-Message-State: AOJu0YwNQAy7tWGJqwFNi0l457NTwPJN8sOaECDF1LNE1xHcgTolBTFB MXalKnQeTDnIC3uPOeE3JJIrxv3fFo7npDCeUxowmNl+fPOsqSacaFVS+2zerIU+idKFfWc11H4 0IHmQ4HqHU0Pv21ZxNLc7JMhHVcByUWKcr66MKkvWjw== X-Gm-Gg: AY/fxX4kZC6Qn6ffexCpJryqCKwFU1VvhVFtMrJKBYeP4Z1rZ/B1+RFMg9jveoso5oa E4SyB1sEVbe1Zd6VXmvS5mohr5ENp4wX2DriD322FO3vAVmRzmix4nlF/NLF80VTO21UI8ZUjie eE8/yXTVX6DxXTxpI7hZl1OJACaXEMiFKcjvgaHYFjwi691TagxJCYXOSjVKlATh6otvn1w0LrT ehO3Js5EuvmHYw5nidbdweEL+4jhJP3P2xNgX/l0oFON30I12wGpnKT1jLjrcMIt2osiXg= X-Google-Smtp-Source: AGHT+IGJz4jd8OXwNoZzdMaoWAYQicMw0/1zf5DGQrAbpZHJPJoqUej16dTSe+fzUsGfkYjrAAPYsuqPxYnuzgsRaog= X-Received: by 2002:a17:903:17cb:b0:295:24ab:fb06 with SMTP id d9443c01a7336-2a3ee45be5dmr119225335ad.22.1768078451772; Sat, 10 Jan 2026 12:54:11 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <69612e4a.3279b.9f58eba@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Sat, 10 Jan 2026 13:54:00 -0700 X-Gm-Features: AZwV_QipGnbShwgRW8G5vcmd2qxpZeRIGI7hT_JruGSY_C3__HrtSaH-b2PFlUw Message-ID: Subject: Re: git: 67599eef01f5 - main - sys/x86/NOTES: Add vt_efifb To: John Baldwin Cc: Konstantin Belousov , Olivier Certner , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000000d9bdd06480ed8d2" X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4dpW8v07smz3JWB --0000000000000d9bdd06480ed8d2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Jan 10, 2026 at 9:42=E2=80=AFAM John Baldwin wrot= e: > On 1/9/26 21:28, Konstantin Belousov wrote: > > On Fri, Jan 09, 2026 at 04:35:22PM +0000, Olivier Certner wrote: > >> The branch main has been updated by olce: > >> > >> URL: > https://cgit.FreeBSD.org/src/commit/?id=3D67599eef01f5417715f673ec81fc146= 7917c7a10 > >> > >> commit 67599eef01f5417715f673ec81fc1467917c7a10 > >> Author: Olivier Certner > >> AuthorDate: 2026-01-09 16:23:59 +0000 > >> Commit: Olivier Certner > >> CommitDate: 2026-01-09 16:34:56 +0000 > >> > >> sys/x86/NOTES: Add vt_efifb > >> > >> Contrary to what is stated in commit f224591746bd ("Add ASMC_DEBU= G > make > >> option"), the various NOTES files should list all available > options. > > No, the f224591746bd commit is correct. GENERIC + LINT should cover al= l > > options and reverse of them, as much as possible. In other words, LINT > > should be complementary to GENERIC, for most options. > > > > At least this is how bde@ described the intent of LINT, and I think > this is > > a right thing to follow. > > Hmmm, I've always understood it that options that change behavior (like, > say > HZ) should have non-default values in LINT to test the setting of > non-default > options, but that LINT itself should include "all the things" in terms of > coverage, so 'device' statements and 'options' that add in new code like > filesystems should always be in LINT. > That's what I always try to do as well... In addition to documenting what often is an under documented part of the tree. Warner --0000000000000d9bdd06480ed8d2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Sat, Jan 10,= 2026 at 9:42=E2=80=AFAM John Baldwin <jhb@freebsd.org> wrote:
On 1/9/26 21:28, Konstantin Belousov wrote:
> On Fri, Jan 09, 2026 at 04:35:22PM +0000, Olivier Certner wrote:
>> The branch main has been updated by olce:
>>
>> URL: http= s://cgit.FreeBSD.org/src/commit/?id=3D67599eef01f5417715f673ec81fc1467917c7= a10
>>
>> commit 67599eef01f5417715f673ec81fc1467917c7a10
>> Author:=C2=A0 =C2=A0 =C2=A0Olivier Certner <olce@FreeBSD.org>= ;
>> AuthorDate: 2026-01-09 16:23:59 +0000
>> Commit:=C2=A0 =C2=A0 =C2=A0Olivier Certner <olce@FreeBSD.org>= ;
>> CommitDate: 2026-01-09 16:34:56 +0000
>>
>>=C2=A0 =C2=A0 =C2=A0 sys/x86/NOTES: Add vt_efifb
>>=C2=A0 =C2=A0 =C2=A0
>>=C2=A0 =C2=A0 =C2=A0 Contrary to what is stated in commit f22459174= 6bd ("Add ASMC_DEBUG make
>>=C2=A0 =C2=A0 =C2=A0 option"), the various NOTES files should = list all available options.
> No, the f224591746bd commit is correct.=C2=A0 GENERIC + LINT should co= ver all
> options and reverse of them, as much as possible.=C2=A0 In other words= , LINT
> should be complementary to GENERIC, for most options.
>
> At least this is how bde@ described the intent of LINT, and I think th= is is
> a right thing to follow.

Hmmm, I've always understood it that options that change behavior (like= , say
HZ) should have non-default values in LINT to test the setting of non-defau= lt
options, but that LINT itself should include "all the things" in = terms of
coverage, so 'device' statements and 'options' that add in = new code like
filesystems should always be in LINT.

T= hat's what I always try to do as well...=C2=A0 In addition to documenti= ng what often
is an under documented part of the tree.
=
Warner
--0000000000000d9bdd06480ed8d2--