Date: Wed, 5 Apr 2023 17:01:01 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Moin Rahman <bofh@freebsd.org> Cc: ports-committers <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 4cda17ab1458 - main - */*: Refactor java/openjdk7 removal Message-ID: <ZC2pTYQxRCLIVTzz@FreeBSD.org> In-Reply-To: <C6B9985A-B836-405E-9ED8-E0DDF4D85EFC@freebsd.org> References: <202304041811.334IB93k074119@gitrepo.freebsd.org> <ZC2YSAqMmDW%2BgJF%2B@FreeBSD.org> <C6B9985A-B836-405E-9ED8-E0DDF4D85EFC@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Apr 05, 2023 at 06:59:15PM +0200, Moin Rahman wrote: > > On Apr 5, 2023, at 5:48 PM, Alexey Dokuchaev <danfe@FreeBSD.org> wrote: > > On Tue, Apr 04, 2023 at 06:11:09PM +0000, Muhammad Moinur Rahman wrote: > >> commit 4cda17ab14588e6e4fdac7f697e246554ce82af3 > >> > >> Refactor java/openjdk7 removal > >> > >> - Since the introduction of jdk version 18 it looks like similar with > >> jdk version 8(java version string 1.8). This is prone to error as it > >> looks similar and is only seperated by a '.'. Remove using > >> JAVA_VERSION with dotted fomat of java version string and update all > >> consumers to utilize version 8 instead of 1.8. > >> > >> @@ -17,7 +17,7 @@ NO_WRKSUBDIR= yes > >> > >> USES= zip:infozip > >> USE_JAVA= yes > >> -JAVA_VERSION= 1.8+ > >> +JAVA_VERSION= 8+ > > > > Perhaps we should drop JAVA_VERSION as USE_JAVA accepts versions similar > > to USE_GCC; separate JAVA_VERSION is just a needless cognitive burden. > > You speak my mind; but one step at a time. That is planned in step 2 and in > step 3 I am going to convert this into USES=java. Awesome, thank you! ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZC2pTYQxRCLIVTzz>