From owner-svn-src-all@freebsd.org Sat Feb 17 15:07:34 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 21EC2F16A00 for ; Sat, 17 Feb 2018 15:07:34 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x230.google.com (mail-it0-x230.google.com [IPv6:2607:f8b0:4001:c0b::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A52E583C24 for ; Sat, 17 Feb 2018 15:07:33 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x230.google.com with SMTP id y16so4893951itc.0 for ; Sat, 17 Feb 2018 07:07:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=LMc55vynpfNpP2IZ03Giy9p/nvQTjNytGUd/ZaEoEqw=; b=LLFtguy5mU9HZM55Q5sGt205tcj2yV3gqhAuHG1D2MBK8a+9fjSE1BxQvGry6uVeBP UMwgAeyemzpBn4sGuieVq682L/AaALokKQcDK5NTYQFgv+B1Qx8VJy8THI2Y0RmhP/UC IPv0rdhkjB1z9YyuV2TBfINvuh/au8UfxAa9/tqwX+4d4Q4Dza21lo3DLGgHo3rnBwgK /bWaWQ8KEag3JvuvbHmNzvjq3gXYbA9mLGlYvbnim/OzMARjICyakhP6QT5DT2jn72r1 UkXJlm0bhNjhPVu1R4WwLchBA7Px03quba913uB8398KqLOJ0Cqq9lN3BD951+7NTcui uYbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=LMc55vynpfNpP2IZ03Giy9p/nvQTjNytGUd/ZaEoEqw=; b=gOk1cMPWzLI7vBoWX6fTvRBucQ/wnbhMEh/Blr418iJoG9/KvLuY5tEVFrOR+qCvJa R0Xo86uUAUsGHlTbJ5FQKxqzfb7dZkpcX1IuAh5nBrphqLVwMxExgZHckSb3tsNH7boj M3lwgEjMXtdAXV9SfjJB12/GIaqWL5FFcJrjpIxdE8XvJggFbEKUs15DNxtSNzGEBpLh ifvXtBm10Wjt9B+iV22mVujqnyPCo1gz70h7jTC973LD3iiUpDWdrLCMRseFEprdKIu0 bFAlSnShMfhuCZYBtjNXT3jMMLX/RJcVnyhAj1rtfpAvArmFZZmM2iHb2Lj0U8+zsU9F wnkA== X-Gm-Message-State: APf1xPCR9AtuGZ3ZlArXkWR3A0P2aliKOHzaujieL3h5dI6xId5RPekH VuT6tbD2PLUDdr8rIi+xwIOhR3ZTP9PDAomLyDpF8g== X-Google-Smtp-Source: AH8x224lM9KpVMHHDudWZ6qwzekaHsDivuhJFusz2SaoEnz+sp9E3WEoRv/geacEaHaxr2fgDgbCIR9xGRyHZKpvrG0= X-Received: by 10.36.55.146 with SMTP id r140mr2101041itr.57.1518880053045; Sat, 17 Feb 2018 07:07:33 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.201.67 with HTTP; Sat, 17 Feb 2018 07:07:32 -0800 (PST) X-Originating-IP: [50.253.99.174] In-Reply-To: <5b49c102-ad07-cfdb-2e45-e27cee99ee81@selasky.org> References: <201802171434.w1HEYl8I063603@repo.freebsd.org> <5b49c102-ad07-cfdb-2e45-e27cee99ee81@selasky.org> From: Warner Losh Date: Sat, 17 Feb 2018 08:07:32 -0700 X-Google-Sender-Auth: dbe2BymbcSBsk2bhC3o3wvmXqvQ Message-ID: Subject: Re: svn commit: r329458 - head/sbin/devmatch To: Hans Petter Selasky Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Feb 2018 15:07:34 -0000 On Sat, Feb 17, 2018 at 7:58 AM, Hans Petter Selasky wrote: > On 02/17/18 15:56, Warner Losh wrote: > >> I'd request you make no further changes to devmatch without a review. >> > > I don't have a problem with that. > > You can see now what changes are needed. Please make sure you test with > real USB devices! Some people are using FreeBSD-current on desktops, and > the USB auto-load feature has been broken for almost a week now. (a) It's current (b) It took longer to sort out than I'd hoped (c) I tested with a keyboard and mouse on my main server. It was absolutely tested. Snide comments like this aren't helping my already grumpy mood over this. It would be more helpful if you could turn on devd's logging (by adding !devd *.>=info /var/log/devd.log to /etc/syslog.conf, restarting syslog and then giving me the exact scenario that's failing so I can add it to a test suite I'm writing. The data will be in /var/log/devd.log. I can't possibly test all the crazy USB scenarios with the hardware I have (there's too many of them), but I can test it in simulation and make sure we're good. The multiple driver matching thing was never ever mentioned in prior things, so getting snippy with me over it for not testing it is not helpful. Understanding what to look for will be helpful in making sure the test suites catch it and we fix the underlying issues. Warner