From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Feb 28 09:40:12 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EFA9C16A4CE for ; Sat, 28 Feb 2004 09:40:11 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id E666A43D1F for ; Sat, 28 Feb 2004 09:40:11 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i1SHeBbv072074 for ; Sat, 28 Feb 2004 09:40:11 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i1SHeBMe072073; Sat, 28 Feb 2004 09:40:11 -0800 (PST) (envelope-from gnats) Resent-Date: Sat, 28 Feb 2004 09:40:11 -0800 (PST) Resent-Message-Id: <200402281740.i1SHeBMe072073@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, michael johnson Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B988D16A4CE for ; Sat, 28 Feb 2004 09:34:17 -0800 (PST) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9B2B143D1D for ; Sat, 28 Feb 2004 09:34:17 -0800 (PST) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.12.10/8.12.10) with ESMTP id i1SHYH72057259 for ; Sat, 28 Feb 2004 09:34:17 -0800 (PST) (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.12.10/8.12.10/Submit) id i1SHYH5s057258; Sat, 28 Feb 2004 09:34:17 -0800 (PST) (envelope-from nobody) Message-Id: <200402281734.i1SHYH5s057258@www.freebsd.org> Date: Sat, 28 Feb 2004 09:34:17 -0800 (PST) From: michael johnson To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Subject: ports/63505: [Patch] multimedia/libfame -- SSE support does not work right X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Feb 2004 17:40:12 -0000 >Number: 63505 >Category: ports >Synopsis: [Patch] multimedia/libfame -- SSE support does not work right >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Feb 28 09:40:11 PST 2004 >Closed-Date: >Last-Modified: >Originator: michael johnson >Release: 5.2-CURRENT >Organization: >Environment: >Description: The way SSE is enabled right now is backwards, if you define WITH_SSE it disables it and if you don't define WITH_SSE it is enabled. I am submitting 2 patches to fix this. If we want SSE enabled default use patch1, if we want SSE to be enabled when defined use patch2. Orignally in http://www.freebsd.org/cgi/query-pr.cgi?pr=63417 I choose to use patch2 because mplayer enables SSE default. Patch1 o Works the opposite of myplayer and disables it default and adds WITH_SSE Patch2 o Works the same way mplayer does, enables it default and adds WITHOUT_SSE >How-To-Repeat: === Begin Patch1 === diff -ruN multimedia/libfame.orig/Makefile multimedia/libfame/Makefile --- multimedia/libfame.orig/Makefile Sat Feb 28 12:15:17 2004 +++ multimedia/libfame/Makefile Sat Feb 28 12:25:50 2004 @@ -18,7 +18,7 @@ USE_LIBTOOL= yes INSTALLS_SHLIB= yes -.if !defined(WITH_SSE) +.if defined(WITH_SSE) CONFIGURE_ARGS+= --enable-sse .endif @@ -33,7 +33,7 @@ fame_start_frame.3 fame_end_frame.3 pre-everything:: -.if !defined(WITHOUT_SSE) +.if !defined(WITH_SSE) @${ECHO_MSG} " You can enable SSE optimized routines by defining WITH_SSE." @${ECHO_MSG} "" .endif === End Patch1 === === Begin Patch2 === diff -ruN multimedia/libfame.orig/Makefile multimedia/libfame/Makefile --- multimedia/libfame.orig/Makefile Sat Feb 28 12:15:17 2004 +++ multimedia/libfame/Makefile Sat Feb 28 12:30:06 2004 @@ -18,7 +18,7 @@ USE_LIBTOOL= yes INSTALLS_SHLIB= yes -.if !defined(WITH_SSE) +.if !defined(WITHOUT_SSE) CONFIGURE_ARGS+= --enable-sse .endif @@ -34,7 +34,7 @@ pre-everything:: .if !defined(WITHOUT_SSE) - @${ECHO_MSG} " You can enable SSE optimized routines by defining WITH_SSE." + @${ECHO_MSG} " You can disable SSE optimized routines by defining WITHOUT_SSE." @${ECHO_MSG} "" .endif === End Patch2 === >Fix: >Release-Note: >Audit-Trail: >Unformatted: