From owner-svn-src-all@freebsd.org Thu Mar 30 23:02:33 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C6C82D26883; Thu, 30 Mar 2017 23:02:33 +0000 (UTC) (envelope-from hiren@strugglingcoder.info) Received: from mail.strugglingcoder.info (strugglingcoder.info [104.236.146.68]) by mx1.freebsd.org (Postfix) with ESMTP id B8F3BDDC; Thu, 30 Mar 2017 23:02:33 +0000 (UTC) (envelope-from hiren@strugglingcoder.info) Received: from localhost (unknown [10.1.1.3]) (Authenticated sender: hiren@strugglingcoder.info) by mail.strugglingcoder.info (Postfix) with ESMTPA id 095701767E; Thu, 30 Mar 2017 16:02:28 -0700 (PDT) Date: Thu, 30 Mar 2017 16:02:27 -0700 From: hiren panchasara To: David C Somayajulu Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316309 - head/sys/dev/qlxgbe Message-ID: <20170330230227.GH1016@strugglingcoder.info> References: <201703302243.v2UMhX2s011405@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1QGDfz3Tkbtkncdd" Content-Disposition: inline In-Reply-To: <201703302243.v2UMhX2s011405@repo.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 23:02:33 -0000 --1QGDfz3Tkbtkncdd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 03/30/17 at 10:43P, David C Somayajulu wrote: > Author: davidcs > Date: Thu Mar 30 22:43:32 2017 > New Revision: 316309 > URL: https://svnweb.freebsd.org/changeset/base/316309 >=20 > Log: > Add support for optional Soft LRO Hi David, I know this is not a new topic but a little more descriptive commit-log would have been nicer. Also, you should update the manpage reflecting this change. i.e. now it also supports software LRO when h/w LRO is disabled. Do you know of a case where one would want to disable h/w lro and enable s/w lro? I guess where you want to free up nic and make cpu do more work? Cheers, Hiren --1QGDfz3Tkbtkncdd Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQF8BAABCgBmBQJY3Y6BXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4 QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/lFBsH+QEjnM1Jebfxpr/KDFfqbiO9 6+gZwShD2R/vCl74ZA99QQPxUUpQjsgKExRit2VpNkGyx1TftAd6nnvHXYHMTSTP KUox7TKhZew3WJW0wVs+A0alaR8m2J753gZXofZnPWYWKRtSw5FRTvz6E6sHcrp6 iumpM1vrYMAtt/G5LRnDTxsWB/Qvegt9bLHu+nw9D0hjS+u2wyJUYgSBqsCLUzzd Syn/t9+OBnO68Si4ONFbhLiphFE6BTqrDtoKEejj0npyRCAJTcN2S6/MVXnDHuC6 OQjuL0EnFndnLwpls/sd90FOTbvza7BZF/C/xfZazr6NC63C4RkNbbUHZaSpYdI= =RhTa -----END PGP SIGNATURE----- --1QGDfz3Tkbtkncdd--