From owner-svn-src-all@FreeBSD.ORG Sun Mar 29 22:45:28 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A985C48E for ; Sun, 29 Mar 2015 22:45:28 +0000 (UTC) Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4002F6E2 for ; Sun, 29 Mar 2015 22:45:27 +0000 (UTC) Received: by wixm2 with SMTP id m2so71927672wix.0 for ; Sun, 29 Mar 2015 15:45:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=W12R3Ix4BxIubX1lI5ZJfsUSvM3tiGL78/DnLGVu7es=; b=STtYJhdGgCXCI286OJltoh8zEVH9jNjhvniwlyarzmu0GCZtAh1+ZD2WtdwHkYMZT3 eYSfru2HmCpw3KoV4G9Iz6wVEeLpBbdgWOX7WIoXgPSrRwQ1dCHCfqnR8IJA/yIrAsBC xlKU5KaTBkr/AqcFMpc3Ht9JmrAakMYIqftNU7fI/4QAs7aQC2ilsP4hwGKCSPE64njw g2tde1fWGN6CLuDdVIV6/7arFtY7mxGCK+lZ9jlfHVKs0JyjcwSq/H+VBQhXjgUPAMKI Lpi1KsrlDAEckRstU2/4UK5u0tC7j+sQMSqoQUmVIdlf3wxf3g1O/8rrfoBzK+hB2Ijz XiTQ== X-Gm-Message-State: ALoCoQlo+c6M+vrkux2dqZVw/j3f9SGfoOCfR3HT0ZBsRuMD0pKwmAD38FBkOPC3OxQxH2fvHzeg X-Received: by 10.194.62.74 with SMTP id w10mr56044244wjr.95.1427669120150; Sun, 29 Mar 2015 15:45:20 -0700 (PDT) Received: from [10.10.1.68] (82-69-141-170.dsl.in-addr.zen.co.uk. [82.69.141.170]) by mx.google.com with ESMTPSA id at4sm13037990wjc.16.2015.03.29.15.45.18 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 29 Mar 2015 15:45:19 -0700 (PDT) Message-ID: <55188087.4050601@multiplay.co.uk> Date: Sun, 29 Mar 2015 23:45:27 +0100 From: Steven Hartland User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Alexander Motin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r280822 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs References: <201503292028.t2TKSJ9E016958@svn.freebsd.org> <55187240.4050007@freebsd.org> <5518740A.1050806@FreeBSD.org> In-Reply-To: <5518740A.1050806@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Mar 2015 22:45:28 -0000 On 29/03/2015 22:52, Alexander Motin wrote: > On 30.03.2015 00:44, Steven Hartland wrote: >> Given the upstream nature of this code it may be better to not do >> cosmetic changes like unless they are first upstreamed as it makes >> comparing with the upstream when bringing update harder. > My changes didn't move the code away from the upstream, may be even made > it a bit closer. In places where upstream code has "64 << 20", I changed > our code from "64<<18" to "16 << 20", which I believe both more correct > and closer to upstream. > Cool thanks for clarifying, sounds like we might need a pass over things to see if we can bring in any other changes which may have slipped though the net.