From owner-cvs-all Thu Sep 16 22:48:40 1999 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (Postfix) with ESMTP id 0DC4814D96; Thu, 16 Sep 1999 22:48:37 -0700 (PDT) (envelope-from dillon@FreeBSD.org) Received: (from dillon@localhost) by freefall.freebsd.org (8.9.3/8.9.2) id WAA54151; Thu, 16 Sep 1999 22:48:37 -0700 (PDT) (envelope-from dillon@FreeBSD.org) Message-Id: <199909170548.WAA54151@freefall.freebsd.org> From: Matt Dillon Date: Thu, 16 Sep 1999 22:48:37 -0700 (PDT) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/vm vm_object.c Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk dillon 1999/09/16 22:48:37 PDT Modified files: sys/vm vm_object.c Log: Remove inappropriate VOP_FSYNC from vm_object_page_clean(). The fsync syncs the entire underlying file rather then just the requested range, resulting in huge inefficiencies when the VM system is articulated in a certain way. The VOP_FSYNC was also found to massively reduce NFS performance in certain cases. Change MADV_DONTNEED and MADV_FREE to call vm_page_dontneed() instead of vm_page_deactivate(). Using vm_page_deactivate() causes all inactive and cache pages to be recycled before the dontneed/free page is recycled, effectively flushing our entire VM inactive & cache queues continuously even if only a few pages are being actively MADV free'd and reused (such as occurs with a sequential scan of a memory-mapped file). Reviewed by: Alan Cox , David Greenman Revision Changes Path 1.168 +5 -3 src/sys/vm/vm_object.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message