Date: Sun, 17 Jun 2007 01:43:05 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: mobile@freebsd.org Subject: Fw: cvs commit: src/sys/dev/usb usb_subr.c Message-ID: <20070617.014305.1899944383.imp@bsdimp.com>
next in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
I think this might be the cause of woe for some people who are using
CardBus cards that are really usb host controller + usb hub + usb
device for things like 3G wireless. If this sounds like you, can you
please try this patch?
Warner
[-- Attachment #2 --]
Return-Path: owner-src-committers@FreeBSD.ORG
Delivery-Date: Sun, 17 Jun 2007 01:39:31 -0600
X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on harmony.bsdimp.com
X-Spam-Level:
X-Spam-Status: No, score=-2.6 required=3.5 tests=BAYES_00 autolearn=ham
version=3.1.7
Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53])
by harmony.bsdimp.com (8.13.8/8.13.4) with ESMTP id l5H7ZxNm034399
for <imp@bsdimp.com>; Sun, 17 Jun 2007 01:36:00 -0600 (MDT)
(envelope-from owner-src-committers@FreeBSD.org)
Received: from hub.freebsd.org (hub.freebsd.org [69.147.83.54])
by mx2.freebsd.org (Postfix) with ESMTP id 6F489B85A7
for <imp@bsdimp.com>; Sun, 17 Jun 2007 07:34:03 +0000 (UTC)
(envelope-from owner-src-committers@FreeBSD.org)
Received: by hub.freebsd.org (Postfix)
id 9DD9716A4E7; Sun, 17 Jun 2007 07:34:02 +0000 (UTC)
Delivered-To: imp@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 538)
id 4374716A46B; Sun, 17 Jun 2007 07:34:02 +0000 (UTC)
X-Original-To: src-committers@FreeBSD.org
Delivered-To: src-committers@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
by hub.freebsd.org (Postfix) with ESMTP id 0DE2216A47A;
Sun, 17 Jun 2007 07:34:01 +0000 (UTC) (envelope-from imp@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
by mx1.freebsd.org (Postfix) with ESMTP id C096213C457;
Sun, 17 Jun 2007 07:34:00 +0000 (UTC) (envelope-from imp@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l5H7Y0tt040452;
Sun, 17 Jun 2007 07:34:00 GMT (envelope-from imp@repoman.freebsd.org)
Received: (from imp@localhost)
by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l5H7Y0E4040442;
Sun, 17 Jun 2007 07:34:00 GMT (envelope-from imp)
Message-Id: <200706170734.l5H7Y0E4040442@repoman.freebsd.org>
From: Warner Losh <imp@FreeBSD.ORG>
Date: Sun, 17 Jun 2007 07:34:00 +0000 (UTC)
To: src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject: cvs commit: src/sys/dev/usb usb_subr.c
X-FreeBSD-CVS-Branch: HEAD
Sender: owner-src-committers@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG
X-Greylist: Sender e-mail whitelisted, not delayed by milter-greylist-2.0
(harmony.bsdimp.com [10.0.0.6]);
Sun, 17 Jun 2007 01:36:00 -0600 (MDT)
imp 2007-06-17 07:34:00 UTC
FreeBSD src repository
Modified files:
sys/dev/usb usb_subr.c
Log:
Expand USB_DO_ATTACH inline.
Remove device_t dv, since it is no longer needed.
Add sizeof(device_t) to replace sizeof dv.
Change device_detach(dev) to device_detach(dev->subdevs[i]) since the type
of dev isn't right! Not sure when this was introduced, but it likely would
lead to a crash on disconnect.
MFC After: 1 week
Revision Changes Path
1.93 +8 -12 src/sys/dev/usb/usb_subr.c
http://cvsweb.FreeBSD.ORG/src/sys/dev/usb/usb_subr.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070617.014305.1899944383.imp>