From owner-cvs-src@FreeBSD.ORG  Tue Apr 29 10:55:41 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9DFB137B401; Tue, 29 Apr 2003 10:55:41 -0700 (PDT)
Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 5125843FAF; Tue, 29 Apr 2003 10:55:40 -0700 (PDT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.12.8/8.12.3) with ESMTP id h3THtUA7090563;
	Tue, 29 Apr 2003 11:55:30 -0600 (MDT)
	(envelope-from imp@bsdimp.com)
Date: Tue, 29 Apr 2003 11:55:24 -0600 (MDT)
Message-Id: <20030429.115524.21927823.imp@bsdimp.com>
To: gallatin@cs.duke.edu
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20030429133708.A84234@grasshopper.cs.duke.edu>
References: <200304290545.h3T5j99Y076513@repoman.freebsd.org>
	<20030429133708.A84234@grasshopper.cs.duke.edu>
X-Mailer: Mew version 2.1 on Emacs 21.2 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c if_fxpvar.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Apr 2003 17:55:42 -0000

In message: <20030429133708.A84234@grasshopper.cs.duke.edu>
            Andrew Gallatin <gallatin@cs.duke.edu> writes:
: What is this deadlock with bus_teardown_intr?  Could we possibly fix
: this some other way than by adding (mostly) useless code to the
: critical path? 

I can remove it if it really annoys you that much.  The locking code
itself will swamp the extra load/compare that happens.  It will put
the race back into the code, however.  This likely means that some
higher level of locking is necessary so that we can make sure that the
interrupts can't happen once detach starts.

Warner