From owner-svn-src-head@FreeBSD.ORG  Sat Aug 27 10:01:37 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4B7651065673;
	Sat, 27 Aug 2011 10:01:37 +0000 (UTC)
	(envelope-from rwatson@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 247048FC08;
	Sat, 27 Aug 2011 10:01:37 +0000 (UTC)
Received: from [192.168.2.112]
	(host81-151-180-177.range81-151.btcentralplus.com [81.151.180.177])
	by cyrus.watson.org (Postfix) with ESMTPSA id 95EAE46B06;
	Sat, 27 Aug 2011 06:01:35 -0400 (EDT)
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: "Robert N. M. Watson" <rwatson@freebsd.org>
In-Reply-To: <CAPFoGT-Dz6jaA5MkLf3=r1YAocq-v-qweOCewRKoEXxUKHrr1Q@mail.gmail.com>
Date: Sat, 27 Aug 2011 11:01:34 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <2BCF41D5-3C69-4D35-B56E-D1D84BC8DD89@freebsd.org>
References: <201108262146.p7QLkaBG072083@svn.freebsd.org>
	<CAPFoGT-Dz6jaA5MkLf3=r1YAocq-v-qweOCewRKoEXxUKHrr1Q@mail.gmail.com>
To: Navdeep Parhar <nparhar@gmail.com>
X-Mailer: Apple Mail (2.1084)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r225203 - in head/sys: dev/cfe dev/dcons dev/ofw
	dev/sio dev/syscons dev/uart kern pc98/cbus powerpc/mambo sys
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Aug 2011 10:01:37 -0000


On 27 Aug 2011, at 09:21, Navdeep Parhar wrote:

>>  (3) options BREAK_TO_DEBUGGER and options ALT_BREAK_TO_DEBUGGER =
continue
>>      to behave as before -- only now instead of compiling in
>>      break-to-debugger support, they change the default values of the
>>      above sysctls to enable those features by default.  Current =
kernel
>>      configurations should, therefore, continue to behave as =
expected.
>=20
> Shouldn't opt_comconsole.h be included in subr_kdb.c for this part to
> actually work?


Yes, you're right.

We should almost certainly garbage collect opt_comconsole.h entirely at =
this point, moving the break options into opt_kdb.h as well. It also =
looks like I missed one of the ARM uart implementations during my walk =
of the tree as well. I'll send a follow-up patch to re@ today to refine =
this change further.

(The dcons Makefile also does something odd, in that it sets #define KDB =
in its own opt_kdb.h when built independently of the kernel, but =
actually, that's now #define KDB goes for the base kernel -- it goes in =
opt_global.h. I'll need to ponder what the right thing to do there is, =
and whether it's worth fixing at this point.)

Robert=