From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Mar 13 17:28:20 2004 Return-Path: Delivered-To: freebsd-ports-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2606D16A4CE; Sat, 13 Mar 2004 17:28:20 -0800 (PST) Received: from postman.arcor.de (newsread1.arcor-online.net [151.189.0.146]) by mx1.FreeBSD.org (Postfix) with ESMTP id 84BB643D31; Sat, 13 Mar 2004 17:28:19 -0800 (PST) (envelope-from eikemeier@fillmore-labs.com) Received: from fillmore.dyndns.org (port-212-202-51-138.reverse.qsc.de [212.202.51.138]) (authenticated bits=0)i2E1SHck003863 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Sun, 14 Mar 2004 02:28:17 +0100 (MET) Received: from [172.16.0.2] (helo=fillmore-labs.com) by fillmore.dyndns.org with esmtp (Exim 4.30; FreeBSD) id 1B2KPy-0004os-T6; Sun, 14 Mar 2004 02:27:54 +0100 Message-ID: <4053B51A.9070103@fillmore-labs.com> Date: Sun, 14 Mar 2004 02:27:54 +0100 From: Oliver Eikemeier Organization: Fillmore Labs GmbH - http://www.fillmore-labs.com/ MIME-Version: 1.0 To: Kris Kennaway References: <200403132222.i2DMM4qs070344@freefall.freebsd.org> <1079217571.13553.9.camel@shumai.marcuscom.com> <4053A92D.6010804@fillmore-labs.com> <1079224702.13553.51.camel@shumai.marcuscom.com> <4053AE29.7070802@fillmore-labs.com> <20040314010948.GA85506@xor.obsecurity.org> In-Reply-To: <20040314010948.GA85506@xor.obsecurity.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit User-Agent: KMail/1.5.9 cc: Joe Marcus Clarke cc: freebsd-ports-bugs@FreeBSD.org cc: portmgr@FreeBSD.org cc: Oliver Eikemeier Subject: Re: ports/64233: [PATCH] bsd.port.mk: improved OPTIONS handling X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Mar 2004 01:28:20 -0000 Kris Kennaway wrote: > On Sun, Mar 14, 2004 at 01:58:17AM +0100, Oliver Eikemeier wrote: > >>That should be easy to resolve, but I'll appreciate some feedback before >>I develop a solution. First of all, when BATCH or PACKAGE_BUILDING is set, >>default options are used and no configuration dialog is presented. >> >>So we can either set BATCH in INDEX builds or add another variable, like >>DISABLE_CONFIG. > > BATCH may be appropriate, but it will require careful testing to make > sure it does the right thing. For example, end users want INDEX > builds to use their local options and make.conf settings, but package > builds need to use the default settings without picking up anything > from the local system. Currently I override LOCALBASE and X11BASE, > and __MAKE_CONF to prevent package index builds from seeing installed > host packages and system settings. Name one: DEFAULT_OPTIONS, DEFAULT_SETTINGS, IGNORE_OPTIONS, WITHOUT_OPTIONS ;) >>The issues here are: >> >>- To generate default options I need to write them to a file. Currently >> I'm using the real OPTIONSFILE, so after a `make index' you have a >> saved default configuration for all ports that define OPTIONS. Maybe >> a temporary file would be a better solution here? > > A temporary file may be the way to go; if the options are stored in > the system directory, then if the user builds INDEX and later builds > the port, they won't be presented with the config dialog and the port > will just silently use the default options. I agree. >>- I'm not sure what this does to running times of INDEX builds. > > That's a very important one. The initial OPTIONS processing patch > already slowed down index builds by ~10% because it spawns a shell to > check the options file for every port. I mentioned this to marcus > shortly after it was committed, but I don't know to what extent it was > followed up (it's not yet fixed). I guess that can be removed, now that OPTIONS lives in bsd.port.post.mk. What *will* hurt index build times is that I'll have to spawn another make to build the port with options.