From owner-cvs-src@FreeBSD.ORG Sun Jul 3 00:59:50 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B222316A7EB; Sun, 3 Jul 2005 00:57:03 +0000 (GMT) (envelope-from ps@mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 527DE44E8C; Sun, 3 Jul 2005 00:36:32 +0000 (GMT) (envelope-from ps@mu.org) Received: by elvis.mu.org (Postfix, from userid 1000) id 6210F6D0C2; Sat, 2 Jul 2005 17:36:09 -0700 (PDT) X-Original-To: ps@mu.org Delivered-To: ps@mu.org Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119]) by elvis.mu.org (Postfix) with ESMTP id 2A5025C9BC for ; Tue, 28 Dec 2004 17:21:39 -0800 (PST) Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18]) by mx2.freebsd.org (Postfix) with ESMTP id BD22756B3F for ; Wed, 29 Dec 2004 01:21:27 +0000 (GMT) (envelope-from owner-src-committers@FreeBSD.org) Received: by hub.freebsd.org (Postfix) id 1FAD416A541; Wed, 29 Dec 2004 01:21:23 +0000 (GMT) Delivered-To: ps@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 538) id 3CB6B16A4D0; Wed, 29 Dec 2004 01:21:20 +0000 (GMT) Delivered-To: src-committers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1081816A4CE; Wed, 29 Dec 2004 01:21:19 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DC92843D31; Wed, 29 Dec 2004 01:21:18 +0000 (GMT) (envelope-from julian@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id iBT1LItx075853; Wed, 29 Dec 2004 01:21:18 GMT (envelope-from julian@repoman.freebsd.org) Received: (from julian@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id iBT1LIow075852; Wed, 29 Dec 2004 01:21:18 GMT (envelope-from julian) Message-Id: <200412290121.iBT1LIow075852@repoman.freebsd.org> From: Julian Elischer To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Sender: owner-src-committers@FreeBSD.org Precedence: bulk X-Loop: FreeBSD.ORG X-Spam-Checker-Version: SpamAssassin 3.0.1 (2004-10-22) on elvis.mu.org X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.1 X-Spam-Level: Cc: Subject: cvs commit: src/sys/dev/usb ehci.c ehcivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Sun, 03 Jul 2005 00:59:53 -0000 X-Original-Date: Wed, 29 Dec 2004 01:21:18 +0000 (UTC) X-List-Received-Date: Sun, 03 Jul 2005 00:59:53 -0000 julian 2004-12-29 01:21:18 UTC FreeBSD src repository Modified files: sys/dev/usb ehci.c ehcivar.h Log: Rewrite ehci_abort_xfer() to use the method hinted at in the EHCI spec. to remove a transaction from the async schedule. The previous method didn't work well and led to the hardware writing to free'd buffers etc, as it didn't always know that the transaction had been aborted. Written after consultation with David Brownell who wrote the Linux EHCI driver. As part of this give the sqh structure a "previous" pointer. MFC after: 1 week Revision Changes Path 1.26 +106 -44 src/sys/dev/usb/ehci.c 1.6 +1 -0 src/sys/dev/usb/ehcivar.h