From owner-svn-src-head@FreeBSD.ORG Mon May 21 15:38:46 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D899C1065675; Mon, 21 May 2012 15:38:46 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id ADE1C8FC1E; Mon, 21 May 2012 15:38:46 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 2F554B949; Mon, 21 May 2012 11:38:46 -0400 (EDT) From: John Baldwin To: Gleb Kurtsou Date: Mon, 21 May 2012 11:27:34 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p13; KDE/4.5.5; amd64; ; ) References: <201205181001.q4IA1VED044374@svn.freebsd.org> <201205180941.48076.jhb@freebsd.org> <20120518152436.GA9116@reks> In-Reply-To: <20120518152436.GA9116@reks> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201205211127.34052.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 21 May 2012 11:38:46 -0400 (EDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r235601 - head/include/protocols X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2012 15:38:46 -0000 On Friday, May 18, 2012 11:24:36 am Gleb Kurtsou wrote: > On (18/05/2012 09:41), John Baldwin wrote: > > On Friday, May 18, 2012 6:01:31 am Gleb Kurtsou wrote: > > > Author: gleb > > > Date: Fri May 18 10:01:31 2012 > > > New Revision: 235601 > > > URL: http://svn.freebsd.org/changeset/base/235601 > > > > > > Log: > > > Don't use ino_t in dumprestore protocol definition. > > > > > > Since ino_t size is about to change to 64-bits, replace ino_t used in > > > dump protocol definition with 32-bit dump_ino_t to preserve backward > > > compatibility. At some point, it may be necessary to use spare fields > > > in struct in order to fully support 64-bit inode numbers. > > > > > > Sponsored by: Google Summer of Code 2011 > > > > A question about your stat changes: did you expand dev_t to 32 bits for the > > AFS folks, or did you leave it as 16 bits? > > dev_t is already 32-bit. Changing it to 64-bit was discussed at some > point and from what I recall no decision was made: > > http://marc.info/?t=129119478700005&r=1&w=2 > > I'm going to commit preparatory changes only for now. Then publish diff > for testing. We can still change dev_t to 64-bit if needed. Although I > didn't work on it. Ah, it was 64-bit they asked for. If it is easy to do so, I'd favor changing it since you've already done all the hard work of rolling a new stat structure. I'd rather err on wasting 32-bits for dev_t than having to do all this over again. -- John Baldwin