From owner-freebsd-current@FreeBSD.ORG  Sun Feb 24 11:34:11 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2ACBF16A402;
	Sun, 24 Feb 2008 11:34:11 +0000 (UTC)
	(envelope-from kris@FreeBSD.org)
Received: from weak.local (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 4420E13C455;
	Sun, 24 Feb 2008 11:34:10 +0000 (UTC)
	(envelope-from kris@FreeBSD.org)
Message-ID: <47C15631.5020002@FreeBSD.org>
Date: Sun, 24 Feb 2008 12:34:09 +0100
From: Kris Kennaway <kris@FreeBSD.org>
User-Agent: Thunderbird 2.0.0.9 (Macintosh/20071031)
MIME-Version: 1.0
To: Robert Watson <rwatson@FreeBSD.org>
References: <274346.34322.qm@web63914.mail.re1.yahoo.com>
	<47C14B0F.8050403@FreeBSD.org>
	<20080224110902.K25292@fledge.watson.org>
In-Reply-To: <20080224110902.K25292@fledge.watson.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Barney Cordoba <barney_cordoba@yahoo.com>, current@freebsd.org
Subject: Re: splimp()
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Feb 2008 11:34:11 -0000

Robert Watson wrote:
> On Sun, 24 Feb 2008, Kris Kennaway wrote:
> 
>> Barney Cordoba wrote:
>>> I'm porting some older software to 7.0 and I see that many of the 7.0 
>>> drivers use both locks and splimps() to protect code, particularly 
>>> the firewire driver. What cases would an splimp() be required?
>>
>> spl*() are NOPs that are only left behind in some code as a reminder 
>> of what mutual exclusion protections used to apply, mostly in cases 
>> where there has not been fine-grained locking applied to the code in 
>> question.  In some (most?) cases they serve no useful annotation 
>> purpose and should just be removed.  For newly written code they 
>> should be added.
> 
> I'm pretty sure you meant "should not be added" :-).

Er yes ;)

Kris