From owner-svn-src-all@freebsd.org Fri Oct 23 10:53:51 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4D238A1BB49; Fri, 23 Oct 2015 10:53:51 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id AC91F224; Fri, 23 Oct 2015 10:53:49 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.15.2/8.15.2) with ESMTPS id t9NArlSL007997 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 23 Oct 2015 13:53:47 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.15.2/8.15.2/Submit) id t9NArln6007996; Fri, 23 Oct 2015 13:53:47 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Fri, 23 Oct 2015 13:53:47 +0300 From: Gleb Smirnoff To: Bryan Drewery Cc: Hans Petter Selasky , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r289700 - in head/sys/compat/linuxkpi: . common common/include common/include/asm common/include/linux common/src Message-ID: <20151023105347.GQ97830@FreeBSD.org> References: <201510211501.t9LF1phM000793@repo.freebsd.org> <5627AF01.8070501@FreeBSD.org> <5627B1B5.30607@selasky.org> <5627B24A.4010905@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5627B24A.4010905@FreeBSD.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Oct 2015 10:53:51 -0000 On Wed, Oct 21, 2015 at 08:42:02AM -0700, Bryan Drewery wrote: B> >>> Log: B> >>> Start process of moving the LinuxKPI into the default kernel build by B> >>> creating an empty directory tree. B> >>> B> >>> Sponsored by: Mellanox Technologies B> >>> B> >>> Added: B> >>> head/sys/compat/linuxkpi/ B> >>> head/sys/compat/linuxkpi/common/ B> >>> head/sys/compat/linuxkpi/common/include/ B> >>> head/sys/compat/linuxkpi/common/include/asm/ B> >>> head/sys/compat/linuxkpi/common/include/linux/ B> >>> head/sys/compat/linuxkpi/common/src/ B> >>> B> >> B> >> This makes me think a branch should be used instead. B> >> B> > B> > Most of what will be done is "svn mv" out of "sys/ofed" and changing B> > some include paths in sys/modules and sys/conf . Can you explain why you B> > think a branch is required ? B> B> Because you're splitting commits up that should otherwise not be split B> up. There's no reason to commit empty directories before a 'svn mv' into B> them. +1 Any commit to head should be an atomic change that does something useful: fixes smth, adds something useful, or removes something obsoleted. You can either bring in the linuxkpi to head in a single commit, or, if you prefer to do a serie of commits, where intermediate state is rather meaningless, then you should do this serie in a separate branch, and then produce patch from the branch and commit it to head. There is no need to revert r289700. This is just a note for future. -- Totus tuus, Glebius.