From owner-freebsd-bugs@FreeBSD.ORG  Sun Nov  6 18:50:18 2011
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 165E410656B2
	for <freebsd-bugs@hub.freebsd.org>;
	Sun,  6 Nov 2011 18:50:18 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 366648FC2E
	for <freebsd-bugs@hub.freebsd.org>;
	Sun,  6 Nov 2011 18:50:17 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id pA6IoGFX034760
	for <freebsd-bugs@freefall.freebsd.org>; Sun, 6 Nov 2011 18:50:16 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id pA6IoGHR034759;
	Sun, 6 Nov 2011 18:50:16 GMT (envelope-from gnats)
Date: Sun, 6 Nov 2011 18:50:16 GMT
Message-Id: <201111061850.pA6IoGHR034759@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Kostik Belousov <kostikbel@gmail.com>
Cc: 
Subject: Re: bin/161257: procstat(1): procstat should grow a -l flag to
	display resource limits
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Kostik Belousov <kostikbel@gmail.com>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Nov 2011 18:50:18 -0000

The following reply was made to PR bin/161257; it has been noted by GNATS.

From: Kostik Belousov <kostikbel@gmail.com>
To: Mikolaj Golub <to.my.trociny@gmail.com>
Cc: John Baldwin <jhb@freebsd.org>, bug-followup@freebsd.org,
        Robert Watson <rwatson@freebsd.org>
Subject: Re: bin/161257: procstat(1): procstat should grow a -l flag to display resource limits
Date: Sun, 6 Nov 2011 20:42:34 +0200

 --z4ZopSbJjk0xfBpb
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Sun, Nov 06, 2011 at 08:13:14PM +0200, Kostik Belousov wrote:
 > On Sun, Nov 06, 2011 at 12:21:29AM +0200, Mikolaj Golub wrote:
 > >=20
 > > On Sat, 5 Nov 2011 16:08:39 +0200 Kostik Belousov wrote:
 > >=20
 > >  KB> Please note that we grow the count of resources supported, e.g.
 > >  KB> we got RLIMIT_NPTS and RLIMIT_SWAP for 8.0. At least a comment near
 > >  KB> RLIM_NLIMITS to point anybody adding a new resource, to the kern.p=
 roc.rlimit
 > >  KB> handler, is useful.
 > >=20
 > > Does this look ok?
 > >=20
 > > http://people.freebsd.org/~trociny/resource.h.patch
 > No, it completely misses my point. You should request the person to handle
 > binary compatibility for sysctl, not for the array of names.
 > It should be done in the course of rlimit.patch.
 And you can already handle the future structure grow by doing the following:
 
 	size_t len;
 
 	len =3D req->oldlen;
 	if (sizeof(limp->pl_rlimit) < len)
 		return (EINVAL);
 	error =3D SYSCTL_OUT(req, limp->pl_rlimit, req->oldlen);
 >=20
 > >=20
 > > The update rlimit patch:
 > >=20
 > > http://people.freebsd.org/~trociny/rlimit.1.patch
 > I have no further comments.
 
 
 
 --z4ZopSbJjk0xfBpb
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.18 (FreeBSD)
 
 iEYEARECAAYFAk621RoACgkQC3+MBN1Mb4iU7gCeLWHCiUWbqKkRRBl9vpl8VnFs
 4QgAoKhuRYBOUNzFxsWqzmsOkOYhuzuv
 =dN5n
 -----END PGP SIGNATURE-----
 
 --z4ZopSbJjk0xfBpb--