From owner-svn-src-head@FreeBSD.ORG Tue Feb 15 21:18:43 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C2A1A1065744; Tue, 15 Feb 2011 21:18:43 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 9946F8FC13; Tue, 15 Feb 2011 21:18:42 +0000 (UTC) Received: by wwf26 with SMTP id 26so633927wwf.31 for ; Tue, 15 Feb 2011 13:18:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=rAt0JEkON4Mu0Kry9kFmS4jsJglCRg1RqnSea8FJToc=; b=LHnsZuWp9hLz20HE94UvYc+jg+i1ZQd/4oYkj/bZ+6IApIOKaSBzE3aqveIKA03wRh kcO882pD1cLFTdPDu3prFnkNUV5H10jiKrz/wWHw42+Osx25y3L9lkZolH/+17emsGNs RI9+K2Ck0oNoOJnO7pzFuR7abSfpicW8dPROE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=SjfSnat7JAxWBSIFoDDNLBa8TKpRUY7wZB7l162w87+fMROMm0nQTs0bmZIjKdPbas dpwHuHvTIa30yhmmbxteDO+pU+PRMnIF116fFA7xRIEh5GOfZ/JeJFVNzjEWnXufWrDx TsHi+7a5Wb2TOfDdoSsqJkV3j5ptA4/qLbV1s= MIME-Version: 1.0 Received: by 10.216.51.130 with SMTP id b2mr4802367wec.42.1297804721163; Tue, 15 Feb 2011 13:18:41 -0800 (PST) Sender: yanegomi@gmail.com Received: by 10.216.71.200 with HTTP; Tue, 15 Feb 2011 13:18:41 -0800 (PST) In-Reply-To: <20110215210817.GA64113@freebsd.org> References: <201102152101.p1FL1D5Z044262@svn.freebsd.org> <20110215210817.GA64113@freebsd.org> Date: Tue, 15 Feb 2011 13:18:41 -0800 X-Google-Sender-Auth: hNcZfl64j6znO19H6-61QugAWXg Message-ID: From: Garrett Cooper To: Roman Divacky Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Dimitry Andric Subject: Re: svn commit: r218716 - head/sys/boot/common X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Feb 2011 21:18:43 -0000 On Tue, Feb 15, 2011 at 1:08 PM, Roman Divacky wrote: > I put there u_int8_t for a reason. That reason being that > it's basically struct direct->d_type which is u_int8_t > and not uint8_t. Even though they're technically the same typedef'ed type (I'd keep style consistent according to the argument rdivacky is making). I guess this has about the same bikeshed-ability as my proposal to change all of the *chflags syscalls to use fflags_t instead of u_long/int/etc on freebsd-fs did a few weeks back. Thanks, -Garrett