Date: Thu, 12 Aug 2010 23:38:27 +0200 From: David DEMELIER <demelier.david@gmail.com> To: Ion-Mihai Tetcu <ionut@tetcu.info> Cc: itetcu@freebsd.org, freebsd-ports@freebsd.org Subject: Re: dspam install Message-ID: <AANLkTi=EpYjZ5HL09C4SyCb-o5P4tmEjU3ryMZZYJPH%2B@mail.gmail.com> In-Reply-To: <20100716184716.334da378.ionut@tetcu.info> References: <4C3A2EE7.7020104@paz.bz> <20100711212831.GA17226@magic.hamla.org> <AANLkTikNzfsunMHILOG6oUgJqPQLu9AZQWX0t50HxxRH@mail.gmail.com> <20100712230428.GB18432@magic.hamla.org> <AANLkTikSxrIkpzB-cFiGCwOrggv6-4qp-vgIw08HIIQa@mail.gmail.com> <20100713222839.GA19319@magic.hamla.org> <AANLkTikOCg92LWops9HUHGfIuj-7-Sy1gdnk6GRM7MN1@mail.gmail.com> <20100716184716.334da378.ionut@tetcu.info>
next in thread | previous in thread | raw e-mail | index | archive | help
2010/7/16 Ion-Mihai Tetcu <ionut@tetcu.info>: > On Thu, 15 Jul 2010 22:50:32 +0200 > David DEMELIER <demelier.david@gmail.com> wrote: > >> 2010/7/14 Sahil Tandon <sahil@freebsd.org>: >> > [mail/dspam maintainer Cc:'d] >> > >> > On Tue, 2010-07-13 at 09:46:04 +0200, David DEMELIER wrote: >> > >> >> 2010/7/13 Sahil Tandon <sahil@freebsd.org>: >> >> > On Mon, 2010-07-12 at 21:28:56 +0200, David DEMELIER wrote: >> >> > >> >> >> .if defined(WITH_MYSQL) >> >> >> WANT_MYSQL_VER=3D 55 ... >> >> >> .endif >> >> >> >> >> >> Then if the user wants a different version he still can change usi= ng : >> >> >> WITH_MYSQL_VER=3D 44. >> >> > >> >> > That change by itself will not work because in bsd.database.mk: >> >> > >> >> > =C2=A0.if defined(WITH_MYSQL_VER) && ${WITH_MYSQL_VER} !=3D ${WANT_= MYSQL_VER} >> >> > =C2=A0IGNORE=3D ... >> >> >> >> Then, explain me why do both php5 and php5-pgsql have not >> >> KNOBS/OPTIONS like dspam and work with this variable WITH_PGSQL_VER ? >> > >> > This is a good opportunity for you to learn about how the ports system >> > works. =C2=A0Compare the contents of both ports and also review >> > bsd.database.mk; if, after that, you still do not understand the curre= nt >> > behavior, let us know. > > For short, it's like this because it (AFAIR) not all what we have now > in the framework we had back when I worte the port, and because I > wanted to also be able to depend on the server. > > > -- > Ion-Mihai Tetcu <ionut@tetcu.info> > Hi, I made a lot of changes in the mail/dspam Makefile. Can you take a look at it if you have the time? I want to be sure everything is okay and I didn't test everything right now. The patch is accessible here : http://markand.malikania.fr/dspam.patch Summary of changes : o Huge general cleanup ; o Removed useless *_LOCAL options (for RUN_DEPENDS). If user needs it he will install it ; o Sit on WITH_MYSQL_VER and WITH_PGSQL_VER instead of multiple WITH_MYSQL* options ; o Renamed WebUI option to WEBUI (we usually write them in capital only) ; o Switched USE_* conditionals to WITH_* (depend on option selected). With kind regards. --=20 Demelier David
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTi=EpYjZ5HL09C4SyCb-o5P4tmEjU3ryMZZYJPH%2B>