From owner-freebsd-ipfw@FreeBSD.ORG  Wed Apr  6 13:08:33 2005
Return-Path: <owner-freebsd-ipfw@FreeBSD.ORG>
Delivered-To: freebsd-ipfw@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3F7E516A534
	for <freebsd-ipfw@FreeBSD.org>; Wed,  6 Apr 2005 13:08:33 +0000 (GMT)
Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 13C7343D53
	for <freebsd-ipfw@FreeBSD.org>; Wed,  6 Apr 2005 13:08:32 +0000 (GMT)
	(envelope-from andre@freebsd.org)
Received: (qmail 84888 invoked from network); 6 Apr 2005 12:36:54 -0000
Received: from unknown (HELO freebsd.org) ([62.48.0.53])
          (envelope-sender <andre@freebsd.org>)
          by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP
          for <glebius@FreeBSD.org>; 6 Apr 2005 12:36:54 -0000
Message-ID: <4253DF50.1F8C2D18@freebsd.org>
Date: Wed, 06 Apr 2005 15:08:32 +0200
From: Andre Oppermann <andre@freebsd.org>
X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U)
X-Accept-Language: en
MIME-Version: 1.0
To: Gleb Smirnoff <glebius@FreeBSD.org>
References: <200504050131.j351VGw0025916@atex.rinet.ru>
	<20050405100511.GA41910@cell.sick.ru>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: maxim@FreeBSD.org
cc: freebsd-ipfw@FreeBSD.org
cc: luigi@FreeBSD.org
cc: Oleg Bulyzhin <oleg@rinet.ru>
cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: kern/79546: dummynet & ipfw tee: kernel may hang (endless loop)
X-BeenThere: freebsd-ipfw@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: IPFW Technical Discussions <freebsd-ipfw.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw>,
	<mailto:freebsd-ipfw-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ipfw>
List-Post: <mailto:freebsd-ipfw@freebsd.org>
List-Help: <mailto:freebsd-ipfw-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw>,
	<mailto:freebsd-ipfw-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Apr 2005 13:08:33 -0000

Gleb Smirnoff wrote:
> 
>   Collegues,
> 
>   Can you please look at this PR? I see the suggested fix acceptable for now and
> for ABI frozen RELENG_5 branch.

Yes, the proposed fix fixes the issue at hand.

>   Speaking of HEAD and future RELENG_6, I'd prefer to move the code that searches
> for PACKET_TAG_DIVERT up to ip_fw_pfil.c, like we do it for dummynet and ng_ipfw
> returned packets.
> 
>   What do you think?

This is the way to go.  IPFW2 is not yet fully in line with the new way
of doing things and so far I haven't managed to get the job finished.

-- 
Andre