From owner-freebsd-arch  Fri May 18  7:54:17 2001
Delivered-To: freebsd-arch@freebsd.org
Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65])
	by hub.freebsd.org (Postfix) with ESMTP
	id 86D0037B422; Fri, 18 May 2001 07:54:04 -0700 (PDT)
	(envelope-from ru@whale.sunbay.crimea.ua)
Received: (from ru@localhost)
	by whale.sunbay.crimea.ua (8.11.2/8.11.2) id f4IErZr91193;
	Fri, 18 May 2001 17:53:35 +0300 (EEST)
	(envelope-from ru)
Date: Fri, 18 May 2001 17:53:35 +0300
From: Ruslan Ermilov <ru@FreeBSD.ORG>
To: Brian Somers <brian@Awfulhak.org>, Warner Losh <imp@village.org>,
	Bruce Evans <bde@zeta.org.au>, cvs-all@FreeBSD.ORG,
	current@FreeBSD.ORG, freebsd-arch@FreeBSD.ORG
Subject: Re: Where to put include files (was: cvs commit: src Makefile.inc1)
Message-ID: <20010518175335.A90576@sunbay.com>
Mail-Followup-To: Brian Somers <brian@Awfulhak.org>,
	Warner Losh <imp@village.org>, Bruce Evans <bde@zeta.org.au>,
	cvs-all@FreeBSD.ORG, current@FreeBSD.ORG, freebsd-arch@FreeBSD.ORG
References: <imp@village.org> <200105171637.f4HGbsb65668@hak.lan.Awfulhak.org> <20010517195251.A90318@sunbay.com> <20010518171110.D81893@sunbay.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20010518171110.D81893@sunbay.com>; from ru@FreeBSD.org on Fri, May 18, 2001 at 05:11:11PM +0300
Sender: owner-freebsd-arch@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-arch.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20freebsd-arch>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20freebsd-arch>
X-Loop: FreeBSD.ORG

On Fri, May 18, 2001 at 05:11:11PM +0300, Ruslan Ermilov wrote:
> On Thu, May 17, 2001 at 07:52:51PM +0300, Ruslan Ermilov wrote:
> [...]
> > 
> > There are 59 Makefiles that have -I${.CURDIR}/(../)+sys in them.
> > All these are bogus.  We should get rid of all of them (-I's).
> > 
> > So far, I have found sbin/mount_* use headers from /sys/miscfs/
> > that are not installed into /usr/include, but should be.  Where
> > should these be installed?  /usr/include/fs/<fs_from_miscfs> or
> > should we preserve the /usr/include/miscfs/ layout like in
> > /sys/miscfs?  Modern fs'es install their headers into include/fs
> > and old ones in include/<fs>.
> > 
> I have removed the -I${.CURDIR}/.../sys from the half of Makefiles
> that do not actually need it.  Here is the rest of Makefiles that
> have the -I${.CURDIR}/.../sys in them, and it's currently required
> because they use headers from /sys that do not get installed into
> /usr/include (but should):
> 
[...]
> 
> sbin/mount_null/Makefile
> sbin/mount_portal/Makefile
> sbin/mount_umap/Makefile
> sbin/mount_union/Makefile
> 
FS headers should go into /usr/include/fs/<fs>fs.h, one per
each filesystem.

Boris, could you please move smbfs.h one directory up from the
/usr/include/fs/smbfs/?  Also, installing of smbfs_node.h and
smbfs_subr.h seems to be not required as these are used solely
within the kernel.


Cheers,
-- 
Ruslan Ermilov		Oracle Developer/DBA,
ru@sunbay.com		Sunbay Software AG,
ru@FreeBSD.org		FreeBSD committer,
+380.652.512.251	Simferopol, Ukraine

http://www.FreeBSD.org	The Power To Serve
http://www.oracle.com	Enabling The Information Age

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message