From owner-svn-src-all@freebsd.org Mon Nov 2 15:06:48 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B9FEDA02E93 for ; Mon, 2 Nov 2015 15:06:48 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: from mail-wm0-x22d.google.com (mail-wm0-x22d.google.com [IPv6:2a00:1450:400c:c09::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46B261C47 for ; Mon, 2 Nov 2015 15:06:48 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: by wmec75 with SMTP id c75so63001255wme.1 for ; Mon, 02 Nov 2015 07:06:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd_org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=ZzJN/L1GPVBPfJb/8rtwH5Lm9eXpONO5JVzcfRBg68Q=; b=Gck7XKNyiLRyXxm2S++Gdl+GjxEWlBbMYWtJWkS/38y7LzByfhfDR+Gs8AbfjKKBpa ulpE+IcXK8MSytNMtFG6e5ijND6ITf/RqKcDqL+G6SOauK0J5nM5PDmIQw1Z8r6ol0Te wEJla2JTKE4Xq66I5A/2RNk6IMPEEzjN3d7BxX7B1IJyz/x7jAF8kKupAkMua87tMAws mFhzoDXy7xwR992cMgUTYrFguvCRPEgWgBnduYsdquI/DWFdESkk5vskCFJuGzxscv9i qiXfeHN6mAlWoSpARtk2w+5fiMLbOm5wLrMgaHNhqKh2YX70bJqff8eK2ApLWh9rW4nQ 5kwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=ZzJN/L1GPVBPfJb/8rtwH5Lm9eXpONO5JVzcfRBg68Q=; b=FBFRR7xesqEJxk9ovN8g06S3SSiR+WesDKZkX7rOAL6ymUat2yucX3aguwls+VH4Yu Uq0NojoP6jA9uztm3pnDxgn9/ehrK2vpfMuF88jvZFk38t7uHnnoxk/4pVfN2KDL58f3 0v8ooBsJx0OSO8/X8rUkWJW04XLVc5AQndH+J0phPyz0tCPVgrzzJE8dBIGZS3f436cK hiFi4Xz+tSC1iXehwpfDbHmMEoTXDtVTHf2WxK8LPCMY33nQLnaP1QwEXRWBt4GaxAIt rsvXaxvNSmOjPhXO5PoHOMCH09yOO+2iL2WDVE6PtJhZwSICRWK18NMKYB7L6hFMjyl6 zBPw== X-Gm-Message-State: ALoCoQnXiBIF6PYOwZMNndjot9OTsZPTDXl4MV2A4FZ27TEFvGU9Z7m1W1/aBxfme3+R8C6SXD6X MIME-Version: 1.0 X-Received: by 10.28.13.75 with SMTP id 72mr13407657wmn.20.1446476806799; Mon, 02 Nov 2015 07:06:46 -0800 (PST) Received: by 10.194.240.226 with HTTP; Mon, 2 Nov 2015 07:06:46 -0800 (PST) In-Reply-To: References: <201510231539.t9NFdxPe018130@repo.freebsd.org> <562A564D.9080703@citrix.com> <562E1F8F.3010304@FreeBSD.org> <5632447B.1020402@FreeBSD.org> <56376567.9090100@FreeBSD.org> Date: Mon, 2 Nov 2015 16:06:46 +0100 Message-ID: Subject: Re: svn commit: r289834 - head/sys/x86/x86 From: Oliver Pinter To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: Adrian Chadd , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2015 15:06:48 -0000 On Mon, Nov 2, 2015 at 2:44 PM, Oliver Pinter wrote: > On 11/2/15, Roger Pau Monn=C3=A9 wrote: >> El 29/10/15 a les 22.48, Oliver Pinter ha escrit: >>> Yes, at next week I have time for the test. Please ping me again at >>> Monday. >> >> Ping :). > > Pong. :) I now stared a new build with the patch, so I will report > back 1-2 hours from now. It's better. :) root@nyi-01 src# git show | head -30 commit 8f6110bd2e258b3f4224eb580e99fa142bebc727 Author: Roger Pau Monne Date: Thu Oct 29 12:58:23 2015 +0100 x86/dma_bounce: rework _bus_dmamap_load_ma implementation The implementation of bus_dmamap_load_ma_triv currently calls _bus_dmamap_load_phys on each page that is part of the passed in buffer= . Since each page is treated as an individual buffer, the resulting behav= iour is different from the behaviour of _bus_dmamap_load_buffer. This breaks certain drivers, like Xen blkfront. If an unmapped buffer of size 4096 that starts at offset 13 into the fi= rst page is passed to the current _bus_dmamap_load_ma implementation (so th= e ma array contains two pages), the result is that two segments are created,= one with a size of 4083 and the other with size 13 (because two independant calls to _bus_dmamap_load_phys are performed, one for each physical pag= e). If the same is done with a mapped buffer and calling _bus_dmamap_load_b= uffer the result is that only one segment is created, with a size of 4096. This patch relegates the usage of bus_dmamap_load_ma_triv in x86 bounce buffer code to drivers requesting BUS_DMA_KEEP_PG_OFFSET and implements _bus_dmamap_load_ma so that it's behaviour is the same as the mapped ve= rsion (_bus_dmamap_load_buffer). This patch only modifies the x86 bounce buff= er code, other arches are left untouched. Reviewed by: kib, jah Differential Revision: https://reviews.freebsd.org/D888 Sponsored by: Citrix Systems R&D root@nyi-01 src# uname -a FreeBSD nyi-01.build.hardenedbsd.org 11.0-CURRENT-HBSD FreeBSD 11.0-CURRENT-HBSD #14 8f6110b(jenkins-world-kernel-20151102): Mon Nov 2 09:42:26 EST 2015 root@nyi-01.build.hardenedbsd.org:/usr/obj/usr/src/sys/JENKINS amd64 root@nyi-01 src# uptime 10:05AM up 3 mins, 2 users, load averages: 0.46, 1.09, 0.57 root@nyi-01 src# Now I started a new jenkins build to see the patch under stress. >> >>