From owner-freebsd-fs@freebsd.org Fri Nov 2 20:59:22 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7FB0310DB3B8 for ; Fri, 2 Nov 2018 20:59:22 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660085.outbound.protection.outlook.com [40.107.66.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 107CB7E156; Fri, 2 Nov 2018 20:59:21 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YTOPR0101MB1162.CANPRD01.PROD.OUTLOOK.COM (52.132.50.155) by YTOPR0101MB2026.CANPRD01.PROD.OUTLOOK.COM (52.132.49.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.21; Fri, 2 Nov 2018 20:59:17 +0000 Received: from YTOPR0101MB1162.CANPRD01.PROD.OUTLOOK.COM ([fe80::9c71:6eb6:1bff:727b]) by YTOPR0101MB1162.CANPRD01.PROD.OUTLOOK.COM ([fe80::9c71:6eb6:1bff:727b%3]) with mapi id 15.20.1294.024; Fri, 2 Nov 2018 20:59:17 +0000 From: Rick Macklem To: Andriy Gapon , Konstantin Belousov CC: FreeBSD Filesystems , Josh Paetzel Subject: Re: How to fill in the fsid for file systems? Thread-Topic: How to fill in the fsid for file systems? Thread-Index: AQHUb557F1RNqdJl0kuwS+F5J/DjsKU2/twAgAGdwkKAAGQrgIAAehmGgAMmaACAAFwYtg== Date: Fri, 2 Nov 2018 20:59:17 +0000 Message-ID: References: <20181030012240.GM5335@kib.kiev.ua> , In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rmacklem@uoguelph.ca; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; YTOPR0101MB2026; 6:W1WbuPqosvhX4CisreGr6lZjn9iz0Pze+6HIleBm+bzCLiyBiZDXqx48yrGx6FncKoicsVgb2qf6HSZPT1iYeO0NnkhX6EvQJBB6I+/oR20U5/KJ6rSydo0FV4jk8Lc7ap7l/sEY9XwZu+gg7rnJCqkHr+K7dGReMo8QOMhrwCDizpUlPXOf7ekry/v8Rv2iavIWNdwR0YxC1YZoiXew4RjxmnJTqROJI+fLCZg0VR9CTaGKh8St0253xRqbZQEwzCM2VVnnym394sl+XyGbM7QeVlPNGJSu3P3Y3C5qLRHXVpgp4BqUGQt1XHGSl3i5vdWgatNRLLpVDNoJl3s4kkTxQNoaVuSntRgwCUlWX34kP6R8H9gShmDBJH7O9fpkOHBu5KVwMeC0J4sKk/QqFPyDxyhx3RhXYsYo4h1bOoFbG7BwEh64VySsbX7AWP/HukO/yiagDqhcJPrbIcrskA==; 5:bDFu/oGdqtzxMDfeSG+7N2UjpHkBCxPDFWOpnJP1iOwa4ejnsMjjwsk+yvWn4RKRwOR6VExGpY+QDKCjGBvNjI1npBJpflP6N8lrBOHY8e/GY609IMdUQ431MV/d6kLz0H4JHg3qw2agnG9PfgXnyu1MRRf6/S/9REzlYrQ+iyw=; 7:t/enFopTH9MIUgWnr8BnS+ZLduOQnWedVsUC7VLusUESESNm/0Y4kQpAOiC89DoUwsPAbjebioZRJTPjKCeZi5bt+nHG9xBjdt5Y25AG2TRzUjHLPkp2bJgXBfkw/yIjD0A4VYQwR82UKoY52LnOxQ== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 2e07f2a7-8da3-4221-837d-08d641060dcf x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:YTOPR0101MB2026; x-ms-traffictypediagnostic: YTOPR0101MB2026: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(3231382)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(148016)(149066)(150057)(6041310)(201703131423095)(201702281529075)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(201708071742011)(7699051)(76991095); SRVR:YTOPR0101MB2026; BCL:0; PCL:0; RULEID:; SRVR:YTOPR0101MB2026; x-forefront-prvs: 08444C7C87 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(136003)(346002)(396003)(366004)(39860400002)(189003)(199004)(74482002)(4326008)(2900100001)(33656002)(25786009)(14444005)(102836004)(256004)(6506007)(71190400001)(39060400002)(99286004)(71200400001)(305945005)(2906002)(105586002)(5660300001)(76176011)(74316002)(54906003)(7696005)(786003)(316002)(110136005)(68736007)(106356001)(476003)(11346002)(446003)(46003)(93886005)(486006)(14454004)(186003)(229853002)(6436002)(8936002)(8676002)(81156014)(53936002)(97736004)(6246003)(9686003)(55016002)(478600001)(81166006)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:YTOPR0101MB2026; H:YTOPR0101MB1162.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-microsoft-antispam-message-info: qVz3eX4/ZIptQV877SX1Qtmx15yVDBBy6+aB63IDSHP7sU5REi6uVwroSETUWI9LJl5p1dxthhVTD+uyAOxn24S9b8ClUeDk6ZcEhm47RpDwBG+5EYTvYlpZq+HArSj24U3pQhLkSP+V1zbNSPWkzVAs3BGqdjdD+Orr7Xgkt2vS1hjumiNSu7fZNFww2EKvoY9PVesLn+5YUx50v9SigHchbDAddSnZs9FEx3oYM/30squamLv6ufbEa3pp8T3Re8gXm+eFJwqPwPa1EhxXtyu4uQ7LF9B85eB5V8Tu/xt/0Nb2AgcaDSAx8H3jyoTa7qqQCbKOJB2Gyac3I1Vg6NDrPha6gEopSUs2GZZgKuk= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 2e07f2a7-8da3-4221-837d-08d641060dcf X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2018 20:59:17.6035 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTOPR0101MB2026 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Nov 2018 20:59:22 -0000 Andriy Gapon wrote: >On 31/10/2018 17:50, Rick Macklem wrote: >> Andriy Gapon wrote: >>> One is practical. How do we provide fsid to ZFS filesystems? >>> I mean I would hate to resort to mounting ZFS via fstab just to provide= fsid >>> whereas today ZFS filesystems are mounted auto-magically. >>> We could add a FreeBSD specific fsid ZFS property, but that's also some= extra code. >> Good point. I'm not a ZFS guy, so I wouldn't have thought of this. > >A counter-point to my own point. If we implement the fsid override in the >common code, like vfs_do[n]mount, then we would not need to worry about an= y >filesystem specifics. Yes, and it would make the code easily MFC'able, since it avoids any change= s to struct export_args and mountd.c. There probably is still an argument for rev'ing struct export_args (making ex_flags 64bits so that the high order bits of mnt_flag don't get truncated= ) and allowing the anonymous user to have more than 16 gids, but there would be no rush nor a need to MFC this, I think? I'll code up a generic "fsid=3DN" option and see what others think of the p= atch, rick