From nobody Mon Jul 27 23:11:00 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h8Dq90c4rz6m2GF for ; Mon, 27 Jul 2026 23:11:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h8Dq873B8z3L7J for ; Mon, 27 Jul 2026 23:11:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785193861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9QB5t6sOrC9wP1GS7YBoyoBY7P13QgsU4L1oUokWMjE=; b=oCl/ySDR5Rmu0xHgDuw15MHfGz+CC3+M0Fjk8fz1aqhJdb2vtXeDu6mgBHZx/pyib/Pi7O SLTFMUIyzrPLldaCeDog8oxMGVnfBRalbdv60I+pEZLNEet48m87awjoavzKI4OsDR3uAt WNhM277ztyi37KYWj2sMaAfMiZ0Xpzr6KtStW+VejV+WDqJ/IsPq+ngL0fGI/4Uh5M85W+ D+V5Xu0s/URzfuvsz3ELI3jbQN/+WsVvw/HE5AXOmTsnfDg+w62kGEPShvyOs0Dq58D9Fg wmCD7TskoNExSZ3JEgM30CO6Xra3K0cD808WG0yleErTkXtEOREudAdfTYeR3Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785193861; a=rsa-sha256; cv=none; b=qV4Z9gISzcl9KsNu37JnTsgznJwPrckmFtNfByMbYZ9kwji/UpWIzNfJLv+aW1u/p6bW/Q n6BPq30sHhFdk4McLAzSrDo9ryuJSUR192ckSFlGH6vRHo0D9CEIdTb2o+BagCdRaqeTMF d2Bu55ByMPg/fLXpivDTovfMyhTUZSsdRHXWSgobBblKvYOV7wWYySz5SR1blXP3quVZyr j4HepfF5bc7WNatHdJYj4BI+DT/MOFvFEU+fgi7cejAoUWKXLECfbsPCFVB4zLOTUcPa/v 6FpM0+aBdKp54+AOLUXDZabrKIWyn8rEZVukkzAC3LH4wcRhZpZ/w0ZextYTBw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785193861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9QB5t6sOrC9wP1GS7YBoyoBY7P13QgsU4L1oUokWMjE=; b=g2Ozso5mTaTxwPEyv0s1sAHAOoYxEF/L/bfyLpFy9/juImbbH7/oLA+CbY7qF67vx66jaq beDLhBQ/2R8f/tjJ9rSwtC1juqBCBNuwh0/I72NDkJfggeQU8GNHqS/dyncWhAC3O1Shdx 7RvcnVa4sYc/SeNg6PmAM6+yv7kyx1KbCgMrXSGGdp/m598DbWCEVFZeX8Qo36AYGpZIEI mnvngcXZuqu17zg/KX9uHjNCTyyV4PpbhLqGoBDR7IWuTokcnIfKw+8V2uot+h/fEdBUI2 k+3RzoW3glenenclBPVfaGB24DcjmOqX+RBqf5uhVJkhl+iVB1xpQ26FlLqp4g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h8Dq862QBz1S0Q for ; Mon, 27 Jul 2026 23:11:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 32768 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 27 Jul 2026 23:11:00 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: b02e02958dad - main - libfetch: Fix handling of connection failures List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b02e02958dad2d5ce3675cbc18b9a94635d09e66 Auto-Submitted: auto-generated Date: Mon, 27 Jul 2026 23:11:00 +0000 Message-Id: <6a67e584.32768.6fc20c11@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=b02e02958dad2d5ce3675cbc18b9a94635d09e66 commit b02e02958dad2d5ce3675cbc18b9a94635d09e66 Author: Mark Johnston AuthorDate: 2026-07-27 18:58:34 +0000 Commit: Mark Johnston CommitDate: 2026-07-27 23:03:16 +0000 libfetch: Fix handling of connection failures After commit 848f360c8f9a, if one tries to connect to a closed port, fetch reports "Operation now in progress", which is rather confusing. Return a more useful error message, restoring the old behaviour. Fixes: 848f360c8f9a ("libfetch: Apply timeout to connection attempts") Reviewed by: des MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D58481 --- lib/libfetch/common.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/libfetch/common.c b/lib/libfetch/common.c index dabc8c4b16b3..8ae51d37481b 100644 --- a/lib/libfetch/common.c +++ b/lib/libfetch/common.c @@ -681,6 +681,10 @@ fetch_connect(const char *host, int port, int af, int verbose) delta.tv_usec / 1000; } } + if (pfd.revents & POLLHUP) { + errno = ECONNREFUSED; + break; + } if (pfd.revents == POLLOUT) { /* connection established */ err = 0;