From owner-freebsd-ports@FreeBSD.ORG Thu Dec 4 08:13:41 2008 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 60AE71065672 for ; Thu, 4 Dec 2008 08:13:41 +0000 (UTC) (envelope-from pz-freebsd-ports@ziemba.us) Received: from ziemba.us (208-106-105-148.dsl.static.sonic.net [208.106.105.148]) by mx1.freebsd.org (Postfix) with ESMTP id 32CC18FC0A for ; Thu, 4 Dec 2008 08:13:41 +0000 (UTC) (envelope-from pz-freebsd-ports@ziemba.us) Received: from hairball.ziemba.us (localhost.ziemba.us [127.0.0.1]) by hairball.ziemba.us (8.14.3/8.14.3) with ESMTP id mB48DEQm098497 for ; Thu, 4 Dec 2008 00:13:14 -0800 (PST) (envelope-from pz-freebsd-ports@ziemba.us) Received: (from mailnull@localhost) by hairball.ziemba.us (8.14.3/8.14.3/Submit) id mB48DELl098496 for freebsd-ports@freebsd.org; Thu, 4 Dec 2008 00:13:14 -0800 (PST) (envelope-from pz-freebsd-ports@ziemba.us) X-Authentication-Warning: hairball.ziemba.us: mailnull set sender to pz-freebsd-ports@ziemba.us using -f Received: (from news@localhost) by hairball.ziemba.us (8.14.3/8.14.3/Submit) id mB48DDUi098431 for treehouse-mail-freebsd-ports@hairball.treehouse.napa.ca.us; Thu, 4 Dec 2008 00:13:13 -0800 (PST) (envelope-from news) From: "G. Paul Ziemba" To: freebsd-ports@freebsd.org Date: Thu, 4 Dec 2008 08:13:13 +0000 (UTC) Message-id: References: <20081203131234.GD70240@hades.panopticon> Errors-to: "G. Paul Ziemba" Subject: Re: Proposal: mechanism for local patches X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: paul+usenet@w6yx.stanford.edu List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Dec 2008 08:13:41 -0000 amdmi3@amdmi3.ru (Dmitry Marakasov) writes: >> 1. Good that it's at the end of the do-patch target - that way local >> patches can happen after the "official" patches >Not sure if it's good actually. >On the one hand, you usually have patches against vanilla sources, and >just want to drop them to some dir and have them applied. >Also, there's USE_DOS2UNIX that comes before any actual patching, so for >ports that use USE_DOS2UNIX you'll have to adapt patches by hand. >On the other hand, this may cause conflicts with patches from ports, If the local patches were applied before the official ports patches, the official patches could fail, or they could undo some of the modifications made by local patches. I think it would be an incorrect result. >From the point of view of the local patches, there is potential for variation in the upstream files regardless of whether they are modified by official ports patches, so doing local patching first doesn't let you avoid tweaking local patches from time to time. >Updated version here: >http://people.freebsd.org/~amdmi3/local-patchdir.patch It looks good to me. Thanks! -- G. Paul Ziemba FreeBSD unix: 12:11AM up 3 days, 9:41, 12 users, load averages: 0.42, 0.40, 0.37