From owner-svn-src-all@freebsd.org  Sun Jun  3 21:27:26 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8EB63FDE375;
 Sun,  3 Jun 2018 21:27:26 +0000 (UTC)
 (envelope-from ronald-lists@klop.ws)
Received: from smarthost1.greenhost.nl (smarthost1.greenhost.nl
 [195.190.28.92])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id D9F817DE3B;
 Sun,  3 Jun 2018 21:27:25 +0000 (UTC)
 (envelope-from ronald-lists@klop.ws)
Received: from smtp.greenhost.nl ([213.108.110.112])
 by smarthost1.greenhost.nl with esmtps
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2)
 (envelope-from <ronald-lists@klop.ws>)
 id 1fPaWz-0002uT-Rs; Sun, 03 Jun 2018 23:27:18 +0200
Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes
To: "Eitan Adler" <eadler@freebsd.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org, "Florian Smeets"
 <flo@smeets.xyz>
Subject: Re: svn commit: r334474 - head/usr.bin/top
References: <201806010551.w515pfoB090926@repo.freebsd.org>
 <bea6b96c-d312-2c45-ccc2-f6498df5cb2c@smeets.xyz>
Date: Sun, 03 Jun 2018 23:27:20 +0200
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: "Ronald Klop" <ronald-lists@klop.ws>
Message-ID: <op.zj1xvu1zkndu52@klop.ws>
In-Reply-To: <bea6b96c-d312-2c45-ccc2-f6498df5cb2c@smeets.xyz>
User-Agent: Opera Mail/12.16 (FreeBSD)
X-Authenticated-As-Hash: 398f5522cb258ce43cb679602f8cfe8b62a256d1
X-Virus-Scanned: by clamav at smarthost1.samage.net
X-Spam-Level: /
X-Spam-Score: 0.5
X-Spam-Status: No, score=0.5 required=5.0 tests=ALL_TRUSTED,
 BAYES_60 autolearn=disabled version=3.4.0
X-Scan-Signature: 1fac81774939798d1cdb19633eb460de
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 03 Jun 2018 21:27:26 -0000

On Sun, 03 Jun 2018 19:19:47 +0200, Florian Smeets via svn-src-all  
<svn-src-all@freebsd.org> wrote:

> On 01.06.18 07:51, Eitan Adler wrote:
>> Author: eadler
>> Date: Fri Jun  1 05:51:40 2018
>> New Revision: 334474
>> URL: https://svnweb.freebsd.org/changeset/base/334474
>>
>> Log:
>>   top(1): Display of TID when using 'H' flag
>>
>>   Some users prefer seeing the TID when viewing individual threads. This
>>   makes sense as the PID will be the same for multiple entries. An  
>> attempt
>>   was made to include both, but there is insufficient room. As such,  
>> using
>>   the TID.
>>
>>   While here, rename the header variables to be more understandable.
>>
>>   Discussed with:	mmacy
>>   Reported on:	2009-10-07
>>
>
> Hi,
>
> I think this is a mistake. The 'H' flag should keep the PID, AFAIK you
> cannot use the TID anywhere in top in contrast to the PID. I usually
> start top with the 'S' and 'H' flags. Now I cannot use 'k' to kill a
> process in that view, as I don't see the PID. IMHO showing TIDs should
> be a separate flag, 'h' maybe, as this commit changes current/expected
> behavior (POLA?).
>
> Also, this is not documented in the man page.
>
> Florian
>

+1 for Florian

I also like the PIDs to see which threads belong to the same process.

Ronald.