From owner-svn-ports-all@FreeBSD.ORG  Thu Mar 26 20:19:12 2015
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 25241560;
 Thu, 26 Mar 2015 20:19:12 +0000 (UTC)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id ED100272;
 Thu, 26 Mar 2015 20:19:11 +0000 (UTC)
Received: from [192.168.0.22] (unknown [130.255.19.191])
 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id 4C8C443C3A;
 Thu, 26 Mar 2015 15:19:03 -0500 (CDT)
Message-ID: <551469B1.7090906@marino.st>
Date: Thu, 26 Mar 2015 21:18:57 +0100
From: John Marino <freebsd.contact@marino.st>
Reply-To: marino@freebsd.org
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: Bryan Drewery <bdrewery@FreeBSD.org>, John Marino <marino@FreeBSD.org>,
 ports-committers@freebsd.org, svn-ports-all@freebsd.org, 
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r382339 - in head/x11-toolkits/swt: . files
References: <201503261937.t2QJbgfH048303@svn.freebsd.org>
 <551467E5.7050505@FreeBSD.org> <551468CA.1080200@FreeBSD.org>
In-Reply-To: <551468CA.1080200@FreeBSD.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Mar 2015 20:19:12 -0000

On 3/26/2015 21:15, Bryan Drewery wrote:
> On 3/26/2015 3:11 PM, Bryan Drewery wrote:
>> On 3/26/2015 2:37 PM, John Marino wrote:
>>> Author: marino
>>> Date: Thu Mar 26 19:37:41 2015
>>> New Revision: 382339
>>> URL: https://svnweb.freebsd.org/changeset/ports/382339
>>> QAT: https://qat.redports.org/buildarchive/r382339/
>>>
>>> Log:
>>>   x11-toolkits/swt: Add DragonFly support
>>>   
>>>   Bring in fix from dports (port is not maintained)
>>>
>>> Modified:
>>>   head/x11-toolkits/swt/Makefile
>>>   head/x11-toolkits/swt/files/patch-build.sh
>>>
>>> Modified: head/x11-toolkits/swt/Makefile
>>> ==============================================================================
>>> --- head/x11-toolkits/swt/Makefile	Thu Mar 26 19:33:35 2015	(r382338)
>>> +++ head/x11-toolkits/swt/Makefile	Thu Mar 26 19:37:41 2015	(r382339)
>>> @@ -83,6 +83,10 @@ post-extract:
>>>  	@(cd ${WRKSRC} && ${UNZIP_CMD} -qo "*.zip")
>>>  	@${RM} -f ${WRKSRC}/*.o ${WRKSRC}/*.so ${WRKSRC}/*.jar
>>>  
>>> +post-patch:
>>> +	${SED} -e 's|freebsd|dragonfly|g' ${WRKSRC}/make_freebsd.mak \
>>> +		${WRKSRC}/make_dragonfly.mak
>>> +
>>
>> This being unconditional seems wrong.
>>
> 
> This is what I was talking about on #bsdports earlier. This is
> overly-specific. You could fix this so that both FreeBSD and DragonFly
> and WhateverOS works all the same. Replace freebsd with OPSYS:tl in
> make_freebsd.mak and FreeBSD with OPSYS in build.sh; This is not enough
> but it's in the direction. Considering that make_freebsd.mak and
> make_dragonfly.mak are the same they should be more generic for OPSYS.
> 

There's no point in making it generic because the configure script also
needs to be patched to use it.  Plus it may not work on any OS, I've not
tested it on any other OS.

This port is unmaintained.