From owner-cvs-src@FreeBSD.ORG Mon Aug 9 15:44:19 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B1E3416A4CE; Mon, 9 Aug 2004 15:44:19 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 35EFA43D31; Mon, 9 Aug 2004 15:44:19 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.11/8.12.11) with ESMTP id i79FfBxc059893; Mon, 9 Aug 2004 09:41:11 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 09 Aug 2004 09:41:10 -0600 (MDT) Message-Id: <20040809.094110.04712576.imp@bsdimp.com> To: johan@FreeBSD.ORG From: "M. Warner Losh" In-Reply-To: <20040809.092824.11587387.imp@bsdimp.com> References: <7mllgolwsk.wl@black.imgsrc.co.jp> <20040809061817.GA53369@numeri.campus.luth.se> <20040809.092824.11587387.imp@bsdimp.com> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: kuriyama@imgsrc.co.jp cc: src-committers@FreeBSD.ORG cc: harti@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG cc: cvs-src@FreeBSD.ORG Subject: Re: cvs commit: src/usr.bin/make Makefile main.c nonints.h var.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Aug 2004 15:44:20 -0000 In message: <20040809.092824.11587387.imp@bsdimp.com> "M. Warner Losh" writes: : In message: <20040809061817.GA53369@numeri.campus.luth.se> : Johan Karlsson writes: : : On Mon, Aug 09, 2004 at 14:12 (+0900), Jun Kuriyama wrote: : : > At Tue, 3 Aug 2004 18:56:31 +0000 (UTC), : : > Hartmut Brandt wrote: : : > > Log: : : > > Put variable assignments from the command line into the MAKEFLAGS : : > > variable as required by POSIX. This causes such variables to be : : > > pushed into all sub-makes called by the make (except when the MAKEFLAGS : : > > variable is explicitely changed in the sub-make's environment). : : > > This makes them also mostly un-overrideable in sub-makes except on the : : > > sub-make's command line. Therefor specifying 'make CC=icc' will cause : : > > icc to be used as C compiler in all sub-makes no matter what the Makefiles : : > > itself try to do to the CC variable. : : > > : : > > This patch also corrects the handling of the MFLAGS variable. MFLAGS : : > > contains all the command line flags but not the command line variable : : > > assignments. The evaluation of the .MFLAGS or .MAKEFLAGS target now : : > > changes both MFLAGS and MAKEFLAGS (they used to change MAKEFLAGS only). : : > > Makefiles can use MFLAGS for their own purposes given that they do not : : > > except MFLAGS to be undefined at the beginning and that they don't evaluate : : > > .MFLAGS or .MAKEFLAGS. MFLAGS should be removed for POSIX compliance, : : > > but it is unfortunately heavily used by the X makefiles. : : > : : > I'm using MAKEOBJDIRPREFIX as a make argument to build the world. : : : : Don't. : : According to make(1) it is an environment variable. : : The current man page is stunningly vague about this. It says that it : respects these environment variables, but it doesn't say they have to : be set in the enviornment to the exclusion of setting them on the : command line. So either we can make it work, or document that the variables listed in the environment section must be set as environment variables only. Warner