Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 28 Apr 2023 13:49:39 -0700
From:      Doug Ambrisko <ambrisko@ambrisko.com>
To:        Dmitry Chagin <dchagin@freebsd.org>
Cc:        Doug Ambrisko <ambrisko@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: e133103ab6b3 - main - mrsas(4) fix build on targets that don't define PTRIN.
Message-ID:  <ZEwxY-TGEtJQznE6@ambrisko.com>
In-Reply-To: <ZEwu1tBqLnNmxcW6@heemeyer.club>
References:  <202304282015.33SKFqEg041794@gitrepo.freebsd.org> <ZEwu1tBqLnNmxcW6@heemeyer.club>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 28, 2023 at 11:38:46PM +0300, Dmitry Chagin wrote:
| On Fri, Apr 28, 2023 at 08:15:52PM +0000, Doug Ambrisko wrote:
| > The branch main has been updated by ambrisko:
| > 
| > URL: https://cgit.FreeBSD.org/src/commit/?id=e133103ab6b35d96d06f24825cff6caa298f595a
| > 
| > commit e133103ab6b35d96d06f24825cff6caa298f595a
| > Author:     Doug Ambrisko <ambrisko@FreeBSD.org>
| > AuthorDate: 2023-04-28 20:12:32 +0000
| > Commit:     Doug Ambrisko <ambrisko@FreeBSD.org>
| > CommitDate: 2023-04-28 20:15:43 +0000
| > 
| >     mrsas(4) fix build on targets that don't define PTRIN.
| 
| just
| #include <sys/abi_compat.h>

I wasn't sure and wanted to get the builds fixed and didn't see that
in sys/dev/mfi/* just the define ... but just defining it failed on
amd64!

Thanks for the tip.  I'm testing a build of kernels with that now.

Doug A.
 
| > ---
| >  sys/dev/mrsas/mrsas_ioctl.c | 4 ++++
| >  1 file changed, 4 insertions(+)
| > 
| > diff --git a/sys/dev/mrsas/mrsas_ioctl.c b/sys/dev/mrsas/mrsas_ioctl.c
| > index b8d88c164e81..7f1d9a91ba0f 100644
| > --- a/sys/dev/mrsas/mrsas_ioctl.c
| > +++ b/sys/dev/mrsas/mrsas_ioctl.c
| > @@ -55,6 +55,10 @@ struct mrsas_passthru_cmd {
| >  	int complete;
| >  };
| >  
| > +#ifndef PTRIN
| > +#define PTRIN(p) ((void *)(uintptr_t)(p))
| > +#endif
| > +
| >  /*
| >   * Function prototypes
| >   */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZEwxY-TGEtJQznE6>