From owner-svn-src-all@FreeBSD.ORG Sat Jul 13 19:45:15 2013 Return-Path: <owner-svn-src-all@FreeBSD.ORG> Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 7F208DE8; Sat, 13 Jul 2013 19:45:15 +0000 (UTC) (envelope-from crodr001@gmail.com) Received: from mail-ob0-x231.google.com (mail-ob0-x231.google.com [IPv6:2607:f8b0:4003:c01::231]) by mx1.freebsd.org (Postfix) with ESMTP id 149041E15; Sat, 13 Jul 2013 19:45:15 +0000 (UTC) Received: by mail-ob0-f177.google.com with SMTP id ta17so12474831obb.36 for <multiple recipients>; Sat, 13 Jul 2013 12:45:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=C6dburt0aDMtlmRXKORZMh4gQJf8ttE4vTMCDMP2GBw=; b=Q9z7RtWWl6KtcriAq4GIIxXWVAFzKi56h1WOUOHIpOGRfUFo5uLOeGJRqDv85KrTA1 Neeedk0o/lUG2aHaTgjTbkVi3G5LNCgo783lAUdhnAKeJndZ8zgTZwKPDKMQMObIh7Y/ YugPTV3/UipABwxW8fKco0IImagTkbFPz5MHM0qdMd3dZF9Jsu7EPyGwznrt0NyLAJak jo+EtuAwkoxNXoegmC+PgcC60t/g9zz8Q0nkxs0/LEu0y9xzgENqtYDd28T6HADivuvN aLMhGJLqWUDuat+qdxsPEM98Mq+i3otLrfwcBGcpkrWpgd5g90+W4aC4OUr/kqi/UMzw WocQ== MIME-Version: 1.0 X-Received: by 10.182.87.170 with SMTP id az10mr39823287obb.10.1373744713402; Sat, 13 Jul 2013 12:45:13 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.60.161.200 with HTTP; Sat, 13 Jul 2013 12:45:13 -0700 (PDT) In-Reply-To: <20130713183354.GA2832@gmail.com> References: <CAG=rPVcxvWq-MoXADiv+gLY-d3hhv1GTMO1R14bhLRm9UB9DqA@mail.gmail.com> <20130712202710.GB2757@gmail.com> <CAJ-Vmomv1nEEq9HV9GreQg6KJGos6ffDhFcVUsUuzfCL6h-YQw@mail.gmail.com> <CAJ-Vmokm29XXbQr5uTwEbGGDYo-8WQNsp60b+7Khkteyh+O+6A@mail.gmail.com> <CAJ-VmomidFufKmGUb0YP2pHWu+pF2Os3Fo4JWzkMJDKLqP_ing@mail.gmail.com> <20130713073118.GC2757@gmail.com> <CAG=rPVe_F03LTt1K77p1BSw0hojMm-Ms-oZdhaFgo842AxkmhQ@mail.gmail.com> <20130713111825.GE2757@gmail.com> <20130713141802.GG2757@gmail.com> <CAG=rPVdhjX0SV44vSVTbXq2CAB8xn2+XaGW0ywhYJDd9M3tZ5A@mail.gmail.com> <20130713183354.GA2832@gmail.com> Date: Sat, 13 Jul 2013 12:45:13 -0700 X-Google-Sender-Auth: SCFUEGGHaNEmR9w3Xe3D8blQaDU Message-ID: <CAG=rPVdW3320YaLbx+sWd8-Cp6x8fH7498oN9UWsX6y+A=gdew@mail.gmail.com> Subject: Re: svn commit: r253255 - head/sys/netgraph/bluetooth/drivers/ubt From: Craig Rodrigues <rodrigc@FreeBSD.org> To: Mikolaj Golub <trociny@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Adrian Chadd <adrian@freebsd.org>, src-committers@freebsd.org, Marko Zec <zec@fer.hr> X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" <svn-src-all.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all> List-Post: <mailto:svn-src-all@freebsd.org> List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=subscribe> X-List-Received-Date: Sat, 13 Jul 2013 19:45:15 -0000 On Sat, Jul 13, 2013 at 11:33 AM, Mikolaj Golub <trociny@freebsd.org> wrote: > > Currently I don't have any pluggable device so my testing would not be > very useful. I tried Marko's patch to test kldload/kldunload change, > which is not in your patch. OK, just to double check, based on reading your post: http://lists.freebsd.org/pipermail/svn-src-all/2013-July/071848.html , with Marko's kldload/kldunload change, you encountered kernel panics in PF and IPFW? I also encountered kernel panics in PF with that patch. Maybe we can clean up those modules in a separate pass, and apply the kldload/kldunload fix some time in the future. > > > Concerning your combined patch, as I said previously I don't like very > much that dance with is_default_vnet. What is a purpose of it? As for > me, it only makes the code less readable. I would just set curvnet to > vnet0, as it is in Marko's patch. > Fine by me. I have re-rolled my combined patch to remove the is_default_vnet check and go with Marko's code to set curvnet to vnet0: (1) Combine Adrian and Marko's patches, but omit Marko's changes to kldload/kldunload: http://people.freebsd.org/~rodrigc/vnet-patch-adrian+marko-p2.txt (2) Revert my Bluetooth patch: http://people.freebsd.org/~rodrigc/patch-revert-GRN-253255.txt -- Craig