From owner-svn-src-all@freebsd.org Mon Aug 26 03:50:25 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A03C2CE014; Mon, 26 Aug 2019 03:50:25 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46GyhJ3ZwMz3Kyx; Mon, 26 Aug 2019 03:50:24 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io1-f48.google.com with SMTP id l7so34007240ioj.6; Sun, 25 Aug 2019 20:50:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=6wbovqpq62M6hEcAoDTjKDkb+6dkjLMekazh+A1N9pk=; b=cNfrK25w22FMkf6wsjkCCU1WMLpRRh5HmmovNkUSOZdHHFKrGGc5dB8HKqjQTX6dob I4e1IcszghfqwWizRCydbBtKDm54vSrc14yJIn1gTOlFz0Anm+n/mh0qJSO7FgBMES/Z dX/nv6V+8g3B4lmmGwH5KbXHowQGbyP7SUvl0JQlpLUVtqmEJc7ODbv7thWgxmHQazL0 N3jDQDPv4xlbsYMXLfxeOYwxmoQYQOIHllArXJ+0r6m1ZBq9AdfglgGxbE6wjfUtZGNp KnOvuncUYffSQ70v4OAKb43UhPJEkxJ01oYNk2P0V9kCV3HVWFFqDWL0n3KUoVfdTj14 kXmg== X-Gm-Message-State: APjAAAWFSfFXZyf5PLUUY5Rf5++Bgj1Ulcwm0HIuFI8VZtmGGT8JXD5u mHeEGAOP1Mn1AnrV0rvOHSAu3coj X-Google-Smtp-Source: APXvYqz9iWgT25l0H1gTKCrXSWvMId9CmUF4V4kBL8GTbyYNzryolV24cPS7ti8QdgLl3VyqfI5GtA== X-Received: by 2002:a5d:8599:: with SMTP id f25mr21690204ioj.265.1566791422748; Sun, 25 Aug 2019 20:50:22 -0700 (PDT) Received: from mail-io1-f42.google.com (mail-io1-f42.google.com. [209.85.166.42]) by smtp.gmail.com with ESMTPSA id k3sm12619476ioq.18.2019.08.25.20.50.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Aug 2019 20:50:22 -0700 (PDT) Received: by mail-io1-f42.google.com with SMTP id t3so33875151ioj.12; Sun, 25 Aug 2019 20:50:22 -0700 (PDT) X-Received: by 2002:a02:b604:: with SMTP id h4mr15214116jam.78.1566791422272; Sun, 25 Aug 2019 20:50:22 -0700 (PDT) MIME-Version: 1.0 References: <201908231522.x7NFMLuJ068037@repo.freebsd.org> <20190826.042056.1329861772202588895.hrs@allbsd.org> <20190826014726.mwddt4uwqoulewhh@mutt-hbsd> In-Reply-To: <20190826014726.mwddt4uwqoulewhh@mutt-hbsd> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Sun, 25 Aug 2019 20:50:11 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r351423 - in head: . sbin/ping6 sbin/ping6/tests To: Shawn Webb Cc: svn-src-head , svn-src-all , src-committers Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 46GyhJ3ZwMz3Kyx X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of csecem@gmail.com designates 209.85.166.48 as permitted sender) smtp.mailfrom=csecem@gmail.com X-Spamd-Result: default: False [-5.64 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[cem@freebsd.org]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.988,0]; FORGED_SENDER(0.30)[cem@freebsd.org,csecem@gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[cem@freebsd.org,csecem@gmail.com]; TAGGED_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[48.166.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-2.65)[ip: (-7.52), ipnet: 209.85.128.0/17(-3.35), asn: 15169(-2.33), country: US(-0.05)]; RWL_MAILSPIKE_POSSIBLE(0.00)[48.166.85.209.rep.mailspike.net : 127.0.0.17]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Aug 2019 03:50:25 -0000 On Sun, Aug 25, 2019 at 6:47 PM Shawn Webb wrote: > I wonder if something like this could be done: Something like it could be; I suggested so two hours ago. > Somewhere in ping(8): > bool ping6_compat; > if (strcmp(argv[0], "ping6")) { > ping6_compat = true; You've gotten the sense of the basic C89 function strcmp() backwards. Maybe it's a security feature that way? You can add HardenedStrcmp to your Easy Feature Comparison page. Conrad