Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 14 Jun 2004 04:24:25 GMT
From:      Marcel Moolenaar <marcel@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 54898 for review
Message-ID:  <200406140424.i5E4OP27064535@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=54898

Change 54898 by marcel@marcel_nfs on 2004/06/14 04:23:29

	o Use backingstore convenience macros.
	o Return error conditions to the caller.

Affected files ...

.. //depot/projects/gdb/sys/ia64/ia64/db_trace.c#4 edit

Differences ...

==== //depot/projects/gdb/sys/ia64/ia64/db_trace.c#4 (text+ko) ====

@@ -33,6 +33,7 @@
 
 #include <machine/db_machdep.h>
 #include <machine/frame.h>
+#include <machine/md_var.h>
 #include <machine/pcb.h>
 #include <machine/unwind.h>
 #include <machine/vmparam.h>
@@ -70,15 +71,14 @@
 		if (error)
 			break;
 
-		args = (cfm >> 7) & 0x7f;
+		args = IA64_CFM_SOL(cfm);
 		if (args > 8)
 			args = 8;
 
 		error = unw_step(&rs);
 		if (!error) {
-			error = unw_get_cfm(&rs, &pfs);
-			if (!error) {
-				i = (pfs & 0x7f) - ((pfs >> 7) & 0x7f);
+			if (!unw_get_cfm(&rs, &pfs)) {
+				i = IA64_CFM_SOF(pfs) - IA64_CFM_SOL(pfs);
 				if (args > i)
 					args = i;
 			}
@@ -121,7 +121,7 @@
 	}
 
 	unw_delete(&rs);
-	return (0);
+	return (error);
 }
 
 void



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200406140424.i5E4OP27064535>