From owner-freebsd-current@FreeBSD.ORG Tue Oct 12 19:25:27 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 10C16106564A for ; Tue, 12 Oct 2010 19:25:27 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from mail-gw0-f54.google.com (mail-gw0-f54.google.com [74.125.83.54]) by mx1.freebsd.org (Postfix) with ESMTP id B4D3D8FC17 for ; Tue, 12 Oct 2010 19:25:26 +0000 (UTC) Received: by gwb15 with SMTP id 15so1862800gwb.13 for ; Tue, 12 Oct 2010 12:25:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:from:date:to:cc :subject:message-id:reply-to:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=g42mSB2y8tFsUFMiJepex4HYFEEcMXOwyyhmsARKBUk=; b=ZHYiGTcXuwflSI9Zi2o77LM10cgpzEI0agNQQ3DixJSq8loIHqroqEzqnJl/TqvqAB z56AhYSqvTe6rhNvmHOEhgPSK8Tff/azhxgfSKeC7h0/coybdf/Y1PlRaAOu9WLcCCA8 duhiFZ4hDJibEbkLwL6605X3gfwUlI8dXnsHI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=XsNc7Z7z8ZZesnaMZJ9ccv/tR6wsUm3OjQshLQTfDANWw1wkChNPc5AMkQbKq1qBkF 4FtPm6rK/rAm6rnx41PK0iTXZZmqUUrhhg+2CK3rD+GqaVbjmvrKw6slKupt+qO54Sc4 7EnpN5Jucrmy2XQr00nhr6rwXpqy2JbehxJuo= Received: by 10.236.105.130 with SMTP id k2mr15732990yhg.57.1286911525781; Tue, 12 Oct 2010 12:25:25 -0700 (PDT) Received: from pyunyh@gmail.com ([174.35.1.224]) by mx.google.com with ESMTPS id 28sm10914691anv.6.2010.10.12.12.25.23 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 12 Oct 2010 12:25:24 -0700 (PDT) Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Tue, 12 Oct 2010 12:23:40 -0700 From: Pyun YongHyeon Date: Tue, 12 Oct 2010 12:23:40 -0700 To: Steve Kargl Message-ID: <20101012192340.GG10094@michelle.cdnetworks.com> References: <20101011225331.GA2829@troutmask.apl.washington.edu> <20101011231604.GI4607@michelle.cdnetworks.com> <20101012000216.GA1554@troutmask.apl.washington.edu> <20101012000927.GK4607@michelle.cdnetworks.com> <20101012001510.GA6789@troutmask.apl.washington.edu> <20101012002621.GA1554@troutmask.apl.washington.edu> <20101012003329.GL4607@michelle.cdnetworks.com> <20101012152440.GA1615@troutmask.apl.washington.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101012152440.GA1615@troutmask.apl.washington.edu> User-Agent: Mutt/1.4.2.3i Cc: freebsd-current@freebsd.org Subject: Re: recent bge(4) changes causing problems X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Oct 2010 19:25:27 -0000 On Tue, Oct 12, 2010 at 08:24:40AM -0700, Steve Kargl wrote: > On Mon, Oct 11, 2010 at 05:33:29PM -0700, Pyun YongHyeon wrote: > > > > Thanks for the info. I still suspect r213495 might break BCM5704. > > Due to lack of BCM5704 I still couldn't test it except guessing. > > How about attached one? > > > Index: sys/dev/bge/if_bge.c > > =================================================================== > > --- sys/dev/bge/if_bge.c (revision 213711) > > +++ sys/dev/bge/if_bge.c (working copy) > > @@ -1736,7 +1736,8 @@ > > RCB_WRITE_4(sc, vrcb, bge_hostaddr.bge_addr_hi, 0); > > RCB_WRITE_4(sc, vrcb, bge_hostaddr.bge_addr_lo, 0); > > RCB_WRITE_4(sc, vrcb, bge_maxlen_flags, > > - BGE_RCB_FLAG_RING_DISABLED); > > + BGE_RCB_MAXLEN_FLAGS(sc->bge_return_ring_cnt, > > + BGE_RCB_FLAG_RING_DISABLED)); > > RCB_WRITE_4(sc, vrcb, bge_nicaddr, 0); > > bge_writembx(sc, BGE_MBX_RX_CONS0_LO + > > (i * (sizeof(uint64_t))), 0); > > Unfortunately, this patch does not fix the issue. > > If I revert r213495 via 'svn merge -r213495:213494 .' > in the sys/dev/bge directory, I can build a working > kernel. So, I can confirm that r213495 is the source > of the problem with a BCM5704 based NIC. > Fix committed to HEAD(r213742).