From owner-svn-src-head@FreeBSD.ORG Mon Jan 6 05:16:16 2014 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 40F6E1FD; Mon, 6 Jan 2014 05:16:16 +0000 (UTC) Received: from smtp.fgznet.ch (mail.fgznet.ch [81.92.96.47]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id AA94A1627; Mon, 6 Jan 2014 05:16:14 +0000 (UTC) Received: from deuterium.andreas.nets (dhclient-91-190-14-19.flashcable.ch [91.190.14.19]) by smtp.fgznet.ch (8.13.8/8.13.8/Submit_SMTPAUTH) with ESMTP id s065FpbT054545; Mon, 6 Jan 2014 06:16:03 +0100 (CET) (envelope-from andreast@FreeBSD.org) Message-ID: <52CA3C07.9030002@FreeBSD.org> Date: Mon, 06 Jan 2014 06:15:51 +0100 From: Andreas Tobler User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: Ian Lepore , Zbigniew Bodek Subject: Re: svn commit: r260161 - in head/sys/arm: arm include References: <201401012003.s01K3ngn009757@svn.freebsd.org> <1388976912.1158.331.camel@revolution.hippie.lan> In-Reply-To: <1388976912.1158.331.camel@revolution.hippie.lan> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.64 on 81.92.96.47 Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jan 2014 05:16:16 -0000 On 06.01.14 03:55, Ian Lepore wrote: > On Wed, 2014-01-01 at 20:03 +0000, Zbigniew Bodek wrote: >> Author: zbb >> Date: Wed Jan 1 20:03:48 2014 >> New Revision: 260161 >> URL: http://svnweb.freebsd.org/changeset/base/260161 >> >> Log: >> Add polarity and level support to ARM GIC >> >> Add suport for setting triggering level and polarity in GIC. >> New function pointer was added to nexus which corresponds >> to the function which sets level/sense in the hardware (GIC). >> >> Submitted by: Wojciech Macek >> Obtained from: Semihalf >> >> Modified: >> head/sys/arm/arm/gic.c >> head/sys/arm/arm/intr.c >> head/sys/arm/arm/nexus.c >> head/sys/arm/include/intr.h >> > [...] >> Modified: head/sys/arm/include/intr.h >> ============================================================================== >> --- head/sys/arm/include/intr.h Wed Jan 1 19:38:15 2014 (r260160) >> +++ head/sys/arm/include/intr.h Wed Jan 1 20:03:48 2014 (r260161) >> @@ -68,6 +68,7 @@ >> #endif >> >> #include >> +#include >> >> int arm_get_next_irq(int); >> void arm_mask_irq(uintptr_t); >> @@ -77,6 +78,8 @@ void arm_setup_irqhandler(const char *, >> void *, int, int, void **); >> int arm_remove_irqhandler(int, void *); >> extern void (*arm_post_filter)(void *); >> +extern int (*arm_config_irq)(int irq, enum intr_trigger trig, >> + enum intr_polarity pol); >> >> void gic_init_secondary(void); >> > > It turns out that the new #include in this change is causing the current > arm tinderbox failures. Enums can't have forward decls anymore, so the > fix for this may not be easy. I posted my try to fix this here: http://lists.freebsd.org/pipermail/freebsd-current/2014-January/047694.html Rebuilt 260333 successfully with it. Andreas