Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 28 Jul 2015 05:48:59 +0000 (UTC)
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   svn commit: r285929 - stable/10/usr.sbin/ctladm
Message-ID:  <201507280548.t6S5mxvc027876@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: bapt
Date: Tue Jul 28 05:48:58 2015
New Revision: 285929
URL: https://svnweb.freebsd.org/changeset/base/285929

Log:
  make ctdladm(8) return 0 is everything was ok.
  
  retval is used to test the return of XML_Parse function which is ok if 1 is
  returned and retval it directly returned to the main function and used as an
  exit value.
  
  if all the parsing part is done reset retval to 0 so that the command return 0
  if everything ok
  
  Differential Revision:	https://reviews.freebsd.org/D3102
  Reviewed by:	trasz
  Sponsored by:	gandi.net

Modified:
  stable/10/usr.sbin/ctladm/ctladm.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/usr.sbin/ctladm/ctladm.c
==============================================================================
--- stable/10/usr.sbin/ctladm/ctladm.c	Tue Jul 28 05:46:37 2015	(r285928)
+++ stable/10/usr.sbin/ctladm/ctladm.c	Tue Jul 28 05:48:58 2015	(r285929)
@@ -3657,6 +3657,7 @@ retry:
 		retval = 1;
 		goto bailout;
 	}
+	retval = 0;
 	XML_ParserFree(parser);
 
 	if (verbose != 0) {
@@ -4075,6 +4076,7 @@ retry:
 		retval = 1;
 		goto bailout;
 	}
+	retval = 0;
 	XML_ParserFree(parser);
 
 	printf("LUN Backend  %18s %4s %-16s %-16s\n", "Size (Blocks)", "BS",
@@ -4371,6 +4373,7 @@ retry:
 		retval = 1;
 		goto bailout;
 	}
+	retval = 0;
 	XML_ParserFree(parser);
 
 	if (quiet == 0)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201507280548.t6S5mxvc027876>