From owner-freebsd-net Fri Oct 26 13:28:54 2001 Delivered-To: freebsd-net@freebsd.org Received: from mail-green.research.att.com (H-135-207-30-103.research.att.com [135.207.30.103]) by hub.freebsd.org (Postfix) with ESMTP id 0DE4337B53A for ; Fri, 26 Oct 2001 13:28:49 -0700 (PDT) Received: from alliance.research.att.com (alliance.research.att.com [135.207.26.26]) by mail-green.research.att.com (Postfix) with ESMTP id B540B1E011; Fri, 26 Oct 2001 16:28:47 -0400 (EDT) Received: from windsor.research.att.com (windsor.research.att.com [135.207.26.46]) by alliance.research.att.com (8.8.7/8.8.7) with ESMTP id QAA23537; Fri, 26 Oct 2001 16:28:38 -0400 (EDT) From: Bill Fenner Received: (from fenner@localhost) by windsor.research.att.com (8.8.8+Sun/8.8.5) id NAA12437; Fri, 26 Oct 2001 13:28:38 -0700 (PDT) Message-Id: <200110262028.NAA12437@windsor.research.att.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII To: bmilekic@technokratis.com Subject: Re: performance issues with M_PREPEND on clusters Cc: rizzo@aciri.org, keiichi@iij.ad.jp, dwmalone@maths.tcd.ie, bright@mu.org, net@freebsd.org References: <20011023110307.A34494@iguana.aciri.org> <20011023132813.I15052@elvis.mu.org> <20011023114650.C34494@iguana.aciri.org> <20011023140034.M15052@elvis.mu.org> <20011023140628.A36095@iguana.aciri.org> <20011023185759.A328@technokratis.com> <20011026110635.B14635@walton.maths.tcd.ie> <86u1wmlj1s.wl@keiichi01.osaka.iij.ad.jp> <20011026121724.A21512@technokratis.com> <20011026092840.F64631@iguana.aciri.org> <20011026133827.A22096@technokratis.com> Date: Fri, 26 Oct 2001 13:28:37 -0700 Versions: dmail (solaris) 2.2j/makemail 2.9b Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org > The M_LEADINGSPACE macro always had the line of code that would return >the leading space even for ext_bufs commented out, suggesting that the >code did exist in the original implementation or was intended to. The M_LEADINGSPACE macro was introduced in rev 7.11 of mbuf.h, in August 1988, at the same time as the "new" mbufs, i.e. when external sotrage was introduced, m_act renamed to m_nextpkt, etc. Perhaps the commented code is there to remind what the right thing to do is once you can tell whether or not external storage is writable. I don't think it's reasonable to say that the presence of the comment makes it completely obvious what the intentions of this code were in 1988. Bill To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message