From owner-freebsd-ports Sun Mar 17 1: 2:30 2002 Delivered-To: freebsd-ports@freebsd.org Received: from wwweasel.geeksrus.net (wwweasel.geeksrus.net [64.8.210.226]) by hub.freebsd.org (Postfix) with ESMTP id 1D7B237B400; Sun, 17 Mar 2002 01:02:23 -0800 (PST) Received: (from alane@localhost) by wwweasel.geeksrus.net (8.11.6/8.11.6) id g2H91lF67859; Sun, 17 Mar 2002 04:01:47 -0500 (EST) (envelope-from alane) Date: Sun, 17 Mar 2002 04:01:47 -0500 From: Alan Eldridge To: sobomax@FreeBSD.ORG Cc: Will Andrews , Kris Kennaway , Will Andrews , ports@FreeBSD.ORG, ports@geeksrus.net Subject: Re: cvs commit: ports/x11/XFree86-4 Makefile Makefile.man pkg-plist pkg-plist.alpha pkg-plist.pc98 ports/x11/XFree86-4/files patch-2 patch-c patch-c2 patch-d patch-f patch-i810 patch-j patch-k patch-mouse patch-r128 patch-r128dri patch-r128xmesa patch-shm ... Message-ID: <20020317090147.GA67681@wwweasel.geeksrus.net> References: <200203162343.g2GNhjs90185@freefall.freebsd.org> <20020316171808.A15093@xor.obsecurity.org> <20020317022158.GK53073@squall.waterspout.com> <1016353719.256.16.camel@notebook> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1016353719.256.16.camel@notebook> User-Agent: Mutt/1.3.28i X-message-flag: Magic 8-Ball says "Outlook not so good." I'll ask it about Exchange next. Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Sun, Mar 17, 2002 at 10:30:05AM +0200, Maxim Sobolev wrote: > >You can use the same approach as mozilla-{headers,embedded} use - i.e. >use shared ${WRKSRC} to build all miniports. See www/mozilla/Makefile, >www/mozilla-embedded/Makefile and www/mozilla-headers/Makefile. This >also simplifies patches management, because you only need to add patch >in one place, not in 9 separate places. Did you see my suggestion? either WRKDIR!= cd ${PORTSDIR}/x11/XFree86 && make -V WRKDIR or WRKSRC!= cd ${PORTSDIR}/x11/XFree86 && make -V WRKSRC Also, unlike the mozilla-* ports, you have to force a make clean before building any of the X miniports. They do some configuration stuff that is positively vile and each one has to start with a clean tree; that may also necessitate separate patch management. ============================================================ Off topic for X, but I need to say this to sobomax while I think of it: Oooh, and that makes me think -- do the mozilla-* ports break if I set my WRKDIR (in make.conf, for example) to something funny? Umm, yes.[1] Notes: [1]Who says that my ${WRKDIR} for mozilla is going to be under ${PORTSDIR}/www/mozilla? I can keep all my WRKDIRs in a separate tree, and break the mozilla-* ports instantly. You need to do what I suggested above for X in the mozilla-* ports. To sobomax: I'll PR that and we can continue discussion there. -- AlanE "When the going gets tough, the weird turn pro." - HST To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message